You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/13 07:11:09 UTC
[GitHub] [flink] wsry opened a new pull request #12879: [FLINK-17636][tests] Fix unstable test SingleInputGateTest#testConcur…
wsry opened a new pull request #12879:
URL: https://github.com/apache/flink/pull/12879
## What is the purpose of the change
Fix unstable test SingleInputGateTest#testConcurrentReadStateAndProcessAndClose.
## Brief change log
- Add synchronization to SingleInputGate#getCloseFuture().
## Verifying this change
This change is already covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12879: [FLINK-17636][tests] Fix unstable test SingleInputGateTest#testConcur…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12879:
URL: https://github.com/apache/flink/pull/12879#issuecomment-657395577
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7fee71eec3d44eab0858f2f2acca3effa00ef2fd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7fee71eec3d44eab0858f2f2acca3effa00ef2fd",
"triggerType" : "PUSH"
}, {
"hash" : "5e9a250176857e0ed8a436703a3948bd34e5558b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4442",
"triggerID" : "5e9a250176857e0ed8a436703a3948bd34e5558b",
"triggerType" : "PUSH"
}, {
"hash" : "0b2d85aa545a2a8d536c5ced4c562bad747c1066",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0b2d85aa545a2a8d536c5ced4c562bad747c1066",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7fee71eec3d44eab0858f2f2acca3effa00ef2fd UNKNOWN
* 5e9a250176857e0ed8a436703a3948bd34e5558b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4442)
* 0b2d85aa545a2a8d536c5ced4c562bad747c1066 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12879: [FLINK-17636][tests] Fix unstable test SingleInputGateTest#testConcur…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12879:
URL: https://github.com/apache/flink/pull/12879#issuecomment-657395577
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7fee71eec3d44eab0858f2f2acca3effa00ef2fd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7fee71eec3d44eab0858f2f2acca3effa00ef2fd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7fee71eec3d44eab0858f2f2acca3effa00ef2fd UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12879: [FLINK-17636][tests] Fix unstable test SingleInputGateTest#testConcur…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12879:
URL: https://github.com/apache/flink/pull/12879#issuecomment-657395577
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7fee71eec3d44eab0858f2f2acca3effa00ef2fd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7fee71eec3d44eab0858f2f2acca3effa00ef2fd",
"triggerType" : "PUSH"
}, {
"hash" : "5e9a250176857e0ed8a436703a3948bd34e5558b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5e9a250176857e0ed8a436703a3948bd34e5558b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7fee71eec3d44eab0858f2f2acca3effa00ef2fd UNKNOWN
* 5e9a250176857e0ed8a436703a3948bd34e5558b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12879: [FLINK-17636][tests] Fix unstable test SingleInputGateTest#testConcur…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12879:
URL: https://github.com/apache/flink/pull/12879#issuecomment-657395577
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7fee71eec3d44eab0858f2f2acca3effa00ef2fd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7fee71eec3d44eab0858f2f2acca3effa00ef2fd",
"triggerType" : "PUSH"
}, {
"hash" : "5e9a250176857e0ed8a436703a3948bd34e5558b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4442",
"triggerID" : "5e9a250176857e0ed8a436703a3948bd34e5558b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7fee71eec3d44eab0858f2f2acca3effa00ef2fd UNKNOWN
* 5e9a250176857e0ed8a436703a3948bd34e5558b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4442)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12879: [FLINK-17636][tests] Fix unstable test SingleInputGateTest#testConcur…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12879:
URL: https://github.com/apache/flink/pull/12879#issuecomment-657395577
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7fee71eec3d44eab0858f2f2acca3effa00ef2fd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7fee71eec3d44eab0858f2f2acca3effa00ef2fd",
"triggerType" : "PUSH"
}, {
"hash" : "5e9a250176857e0ed8a436703a3948bd34e5558b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4442",
"triggerID" : "5e9a250176857e0ed8a436703a3948bd34e5558b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7fee71eec3d44eab0858f2f2acca3effa00ef2fd UNKNOWN
* 5e9a250176857e0ed8a436703a3948bd34e5558b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4442)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12879: [FLINK-17636][tests] Fix unstable test SingleInputGateTest#testConcur…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12879:
URL: https://github.com/apache/flink/pull/12879#issuecomment-657395577
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7fee71eec3d44eab0858f2f2acca3effa00ef2fd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7fee71eec3d44eab0858f2f2acca3effa00ef2fd",
"triggerType" : "PUSH"
}, {
"hash" : "5e9a250176857e0ed8a436703a3948bd34e5558b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4442",
"triggerID" : "5e9a250176857e0ed8a436703a3948bd34e5558b",
"triggerType" : "PUSH"
}, {
"hash" : "0b2d85aa545a2a8d536c5ced4c562bad747c1066",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4496",
"triggerID" : "0b2d85aa545a2a8d536c5ced4c562bad747c1066",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7fee71eec3d44eab0858f2f2acca3effa00ef2fd UNKNOWN
* 0b2d85aa545a2a8d536c5ced4c562bad747c1066 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4496)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12879: [FLINK-17636][tests] Fix unstable test SingleInputGateTest#testConcur…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12879:
URL: https://github.com/apache/flink/pull/12879#issuecomment-657394143
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 8c897c0c117ee453a56a18aed659389d16f8553e (Mon Jul 13 07:13:37 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhijiangW merged pull request #12879: [FLINK-17636][tests] Fix unstable test SingleInputGateTest#testConcur…
Posted by GitBox <gi...@apache.org>.
zhijiangW merged pull request #12879:
URL: https://github.com/apache/flink/pull/12879
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12879: [FLINK-17636][tests] Fix unstable test SingleInputGateTest#testConcur…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12879:
URL: https://github.com/apache/flink/pull/12879#issuecomment-657395577
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7fee71eec3d44eab0858f2f2acca3effa00ef2fd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7fee71eec3d44eab0858f2f2acca3effa00ef2fd",
"triggerType" : "PUSH"
}, {
"hash" : "5e9a250176857e0ed8a436703a3948bd34e5558b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4442",
"triggerID" : "5e9a250176857e0ed8a436703a3948bd34e5558b",
"triggerType" : "PUSH"
}, {
"hash" : "0b2d85aa545a2a8d536c5ced4c562bad747c1066",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4496",
"triggerID" : "0b2d85aa545a2a8d536c5ced4c562bad747c1066",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7fee71eec3d44eab0858f2f2acca3effa00ef2fd UNKNOWN
* 5e9a250176857e0ed8a436703a3948bd34e5558b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4442)
* 0b2d85aa545a2a8d536c5ced4c562bad747c1066 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4496)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org