You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@magpie.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2026/09/26 21:12:39 UTC

[PR] fix: remove Airflow-specific links from skills and templates [magpie]

potiuk opened a new pull request, #1407:
URL: https://github.com/apache/magpie/pull/1407

   ## Problem
   
   Several contributor-facing surfaces linked Airflow's own contributing docs, which do not exist in Magpie or in any other adopting project:
   
   - the four AI-attribution footers of `pr-management-code-review` linked `contributing-docs/05_pull_requests.rst`;
   - five `pr-management-triage` comment templates hardcoded `contributing-docs/05_pull_requests.rst` and `25_maintainer_pr_triage.md`, even though the file already defines `<quality_criteria_url>` and `<two_stage_triage_rationale_url>` for them;
   - `security-issue-fix` linked `contributing-docs/README.md` and baked Airflow's Gen-AI guideline URL into the disclosure block it drafts;
   - two `projects/_template/` examples were filled in with Airflow values and links.
   
   ## Fix
   
   - Review footers link `[Contributing guide](<upstream_contributing_docs_url>)` from `project.md`; when the key is unset, the "More on how …" line is dropped rather than linking to a guess.
   - Triage templates use the placeholders the file already defines.
   - `security-issue-fix` points at the configured contributing docs, and uses the project's own Gen-AI disclosure wording, falling back to a plain `Generated-by:` line.
   - `slop-detection.md` read a non-existent `contributing_docs_url` key; it now reads `upstream_contributing_docs_url`.
   - The two filled template examples use the neutral `Apache Foo` / `foo` example `AGENTS.md` uses.
   
   Airflow URLs used as sample data in unit tests and eval fixtures are left for a separate change.
   
   ## Testing
   
   - `prek run --all-files`: all hooks pass, including `lychee`.
   - No Airflow link remains outside unit-test data and eval fixtures.
   - `security-issue-fix` step-5g evals (the only extracted step touched): 2/3 on this branch and 2/3 on `main`; `case-2-forbidden-term-in-body` fails identically on both.
   - `measured_tokens` restamped.
   
   ## Generative AI disclosure
   
   This change was prepared with Claude Code (Claude Opus 5) and reviewed by the author.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: remove Airflow-specific links from skills and templates [magpie]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #1407:
URL: https://github.com/apache/magpie/pull/1407


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org