[GitHub] [cloudstack] shwstppr commented on a diff in pull request #6851: api,server: fix listing vm metrics for infra resources

[GitBox <gi...@apache.org>]

shwstppr commented on code in PR #6851:
URL: https://github.com/apache/cloudstack/pull/6851#discussion_r1044503899


##########
server/src/main/java/com/cloud/api/query/QueryManagerImpl.java:
##########
@@ -1035,7 +1035,7 @@ private Pair<List<UserVmJoinVO>, Integer> searchForUserVMsInternal(ListVMsCmd cm
         Object backupOfferingId = cmd.getBackupOfferingId();
         Object isHaEnabled = cmd.getHaEnabled();
         Object pod = null;
-        Long clusterId = null;
+        Object clusterId = null;
         Object hostId = null;
         Object storageId = null;
         if (_accountMgr.isRootAdmin(caller.getId())) {

Review Comment:
   @DaanHoogland I am afraid the below code may not work as cmd will be an instance of `ListVMsMetricsCmdByAdmin` and not `ListVMsCmdByAdmin` 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org