[jira] [Commented] (SOLR-4234) ZooKeeper doesn't handle binary files

["Eric Pugh (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543245#comment-13543245 ] 

Eric Pugh commented on SOLR-4234:
---------------------------------

[~markrmiller@gmail.com], [~ehatcher], are there any other changes needed to be made?  And one nice thing about fixing the upload aspect of ZKCli, is that we can potentially load jar files from a Solr Core (./core/lib/myjar.jar), which is something that only non ZK mode works with.   Right now, the ZKCli munges up the binary jar file when you upload to ZK.  
                
> ZooKeeper doesn't handle binary files
> -------------------------------------
>
>                 Key: SOLR-4234
>                 URL: https://issues.apache.org/jira/browse/SOLR-4234
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud
>    Affects Versions: 4.0
>            Reporter: Eric Pugh
>            Assignee: Mark Miller
>             Fix For: 4.1, 5.0
>
>         Attachments: binary_upload_download.patch, fix_show_file_handler_with_binaries.patch
>
>
> I was attempting to get the ShowFileHandler to show a .png file, and it was failing.  But in non-ZK mode it worked just fine!   It took a while, but it seems that we upload to zk as a text, and download as well.  I've attached a unit test that demonstrates the problem, and a fix.  You have to have a binary file in the conf directory to make the test work, I put solr.png in the collection1/conf/velocity directory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org