You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/23 06:56:25 UTC
[GitHub] [spark] kyoty opened a new pull request #32308: [SPARK-35202] The DAG part of sql-execution page should can be hidden/expand.
kyoty opened a new pull request #32308:
URL: https://github.com/apache/spark/pull/32308
### What changes were proposed in this pull request?
The DAG part of sql-execution page should can be hidden/expand instead of being displayed directly all the time.
### Why are the changes needed?
1.if it is a particularly complex SQL, it would take a long time to render the svg, and the page will be stuck for a long time.
2.sometimes we just want to look at the detail of execution plan, but DAG cannot be hidden, and it is often inconvenient to drag the scroll bar to view the execution plan information.
### Does this PR introduce _any_ user-facing change?
Yes, the sql dag can be clicked as hidden or expand.
### How was this patch tested?
manual test works well
before modified:
after modified:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #32308: [SPARK-35202] Make The DAG of sql-execution page can be hidden/expand.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #32308:
URL: https://github.com/apache/spark/pull/32308#issuecomment-922142291
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #32308: [SPARK-35202] Make The DAG of sql-execution page can be hidden/expand.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #32308:
URL: https://github.com/apache/spark/pull/32308
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kyoty commented on pull request #32308: [SPARK-35202] Make The DAG of sql-execution page can be hidden/expand.
Posted by GitBox <gi...@apache.org>.
kyoty commented on pull request #32308:
URL: https://github.com/apache/spark/pull/32308#issuecomment-826534766
cc @gengliangwang @sarutak
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kyoty commented on pull request #32308: [SPARK-35202] Make The DAG of sql-execution page can be hidden/expand.
Posted by GitBox <gi...@apache.org>.
kyoty commented on pull request #32308:
URL: https://github.com/apache/spark/pull/32308#issuecomment-826534766
cc @gengliangwang @sarutak
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kyoty removed a comment on pull request #32308: [SPARK-35202] Make The DAG of sql-execution page can be hidden/expand.
Posted by GitBox <gi...@apache.org>.
kyoty removed a comment on pull request #32308:
URL: https://github.com/apache/spark/pull/32308#issuecomment-826534766
cc @gengliangwang @sarutak
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32308: [SPARK-35202] Make The DAG of sql-execution page can be hidden/expand.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32308:
URL: https://github.com/apache/spark/pull/32308#issuecomment-825445106
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org