You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "westonpace (via GitHub)" <gi...@apache.org> on 2023/07/01 15:34:52 UTC
[GitHub] [arrow] westonpace opened a new issue, #36427: [C++] Add arrow::compute::Expression::Equals option that does not compare fields
westonpace opened a new issue, #36427:
URL: https://github.com/apache/arrow/issues/36427
### Describe the enhancement requested
This would allow an unbound expression to be considered equal to a bound expression as long as they represent the same call (e.g. same number of arguments, same function name, etc.)
When binding we also do some slight massaging of types (e.g. add(foo_i8, 7_i64) converts to add(foo_i8, 7_i8)). This method should not try and correct for that (e.g. those two example expressions would still be considered unequal). It should mainly just avoid looking at the `Call::kernel` field and the field reference types and function types.
Once this is added we should enhance the `test_expression_serialization` test in test_compute.py to use `Expression::Equals` instead of comparing the string representation of expressions.
### Component(s)
C++
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Add arrow::compute::Expression::Equals option that does not compare kernels [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on issue #36427:
URL: https://github.com/apache/arrow/issues/36427#issuecomment-3921765128
This issue has been marked as stale because it has had no activity in the past 2 years. Please remove the stale label or comment below, or this issue will be closed in 14 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Add arrow::compute::Expression::Equals option that does not compare kernels [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic closed issue #36427: [C++] Add arrow::compute::Expression::Equals option that does not compare kernels
URL: https://github.com/apache/arrow/issues/36427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org