You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/10/15 01:44:02 UTC

[GitHub] [servicecomb-service-center] little-cui opened a new pull request #711: SCB-2094 Move the DAO package

little-cui opened a new pull request #711:
URL: https://github.com/apache/servicecomb-service-center/pull/711


   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-service-center] popozy commented on a change in pull request #711: SCB-2094 Move the DAO package

Posted by GitBox <gi...@apache.org>.
popozy commented on a change in pull request #711:
URL: https://github.com/apache/servicecomb-service-center/pull/711#discussion_r505134775



##########
File path: server/service/auth/manager.go
##########
@@ -17,14 +17,15 @@ package auth
 
 import (
 	"fmt"
+	"github.com/apache/servicecomb-service-center/datasource"
 	"github.com/apache/servicecomb-service-center/pkg/log"
 )
 
-type dataSourceEngine func(opts Options) (DataSource, error)
+type dataSourceEngine func(opts Options) (datasource.DataSource, error)

Review comment:
       ok~~LGTM




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-service-center] popozy commented on a change in pull request #711: SCB-2094 Move the DAO package

Posted by GitBox <gi...@apache.org>.
popozy commented on a change in pull request #711:
URL: https://github.com/apache/servicecomb-service-center/pull/711#discussion_r505123899



##########
File path: server/service/auth/manager.go
##########
@@ -17,14 +17,15 @@ package auth
 
 import (
 	"fmt"
+	"github.com/apache/servicecomb-service-center/datasource"
 	"github.com/apache/servicecomb-service-center/pkg/log"
 )
 
-type dataSourceEngine func(opts Options) (DataSource, error)
+type dataSourceEngine func(opts Options) (datasource.DataSource, error)

Review comment:
       Just leave the ms,dep,auth decoupled as three fully seperated plugins or aggreate them to one plugin.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-service-center] little-cui merged pull request #711: SCB-2094 Move the DAO package

Posted by GitBox <gi...@apache.org>.
little-cui merged pull request #711:
URL: https://github.com/apache/servicecomb-service-center/pull/711


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-service-center] little-cui commented on a change in pull request #711: SCB-2094 Move the DAO package

Posted by GitBox <gi...@apache.org>.
little-cui commented on a change in pull request #711:
URL: https://github.com/apache/servicecomb-service-center/pull/711#discussion_r505133849



##########
File path: server/service/auth/manager.go
##########
@@ -17,14 +17,15 @@ package auth
 
 import (
 	"fmt"
+	"github.com/apache/servicecomb-service-center/datasource"
 	"github.com/apache/servicecomb-service-center/pkg/log"
 )
 
-type dataSourceEngine func(opts Options) (DataSource, error)
+type dataSourceEngine func(opts Options) (datasource.DataSource, error)

Review comment:
       Yes, i am going to mv plugin mgr to datasource pkg. I will finish it in Next PR




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-service-center] popozy commented on a change in pull request #711: SCB-2094 Move the DAO package

Posted by GitBox <gi...@apache.org>.
popozy commented on a change in pull request #711:
URL: https://github.com/apache/servicecomb-service-center/pull/711#discussion_r505122959



##########
File path: server/service/auth/manager.go
##########
@@ -17,14 +17,15 @@ package auth
 
 import (
 	"fmt"
+	"github.com/apache/servicecomb-service-center/datasource"
 	"github.com/apache/servicecomb-service-center/pkg/log"
 )
 
-type dataSourceEngine func(opts Options) (DataSource, error)
+type dataSourceEngine func(opts Options) (datasource.DataSource, error)

Review comment:
       I think that plugin mechanism is damaged if plugin's implemention was migrated to service/datasource pkg but leaving plugin manager where it stays before. This will lead to module coupled in my opinion. Refer to https://github.com/go-chassis/go-chassis/tree/master/pkg/backends/quota.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org