You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/07/17 11:55:10 UTC
[GitHub] [dolphinscheduler-website] ZYJBigData opened a new pull request, #813: Notes supplement
ZYJBigData opened a new pull request, #813:
URL: https://github.com/apache/dolphinscheduler-website/pull/813
the update adds the documentation instructions for starting the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] chengshiwen commented on a diff in pull request #813: the update adds the documentation instructions for starting the documentation
Posted by GitBox <gi...@apache.org>.
chengshiwen commented on code in PR #813:
URL: https://github.com/apache/dolphinscheduler-website/pull/813#discussion_r923471698
##########
community/zh-cn/development/document.md:
##########
@@ -22,7 +22,9 @@ DolphinScheduler 网站由 [docsite](https://github.com/chengshiwen/docsite-ext)
1. 在根目录中运行 `npm install` 以安装依赖项。
-2. 运行命令收集资源 2.1. 运行 export PROTOCOL_MODE=ssh 通过 SSH 协议而不是 HTTPS 协议 2.2 告诉 Git 克隆资源。 运行 ./scripts/prepare_docs.sh 准备所有相关资源，有关更多信息，您可以查看准备脚本的工作方式。
+2. 运行命令收集资源：
+ * 运行 `export PROTOCOL_MODE=ssh` 告诉Git克隆资源，通过SSH协议而不是HTTPS协议。
+ * 运行 `./scripts/prepare_docs.sh` 准备所有相关资源，关更多信息，您可以查看[如何准备脚本工作](blob/master/HOW_PREPARE_WOKR.md)。
Review Comment:
Modify the link to https://github.com/apache/dolphinscheduler-website/blob/master/HOW_PREPARE_WOKR.md
##########
community/en-us/development/document.md:
##########
@@ -22,7 +22,9 @@ Make sure that your node version is 10+, docsite does not yet support versions h
1. Run `npm install` in the root directory to install the dependencies.
-2. Run commands to collect resources 2.1. Run export PROTOCOL_MODE=ssh tells Git clone resource via SSH protocol instead of HTTPS protocol 2.2. Run ./scripts/prepare_docs.sh prepare all related resources, for more information you could see how prepare script work.
+2. Run commands to collect resources
+ * Run `export PROTOCOL_MODE=ssh` tells Git clone resource via SSH protocol instead of HTTPS protocol.
+ * Run `./scripts/prepare_docs.sh` prepare all related resources, for more information you could see [how prepare script work](blob/master/HOW_PREPARE_WOKR.md).
Review Comment:
Modify the link to https://github.com/apache/dolphinscheduler-website/blob/master/HOW_PREPARE_WOKR.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] chengshiwen merged pull request #813: the update adds the documentation instructions for starting the documentation
Posted by GitBox <gi...@apache.org>.
chengshiwen merged PR #813:
URL: https://github.com/apache/dolphinscheduler-website/pull/813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] chengshiwen commented on pull request #813: the update adds the documentation instructions for starting the documentation
Posted by GitBox <gi...@apache.org>.
chengshiwen commented on PR #813:
URL: https://github.com/apache/dolphinscheduler-website/pull/813#issuecomment-1188965301
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] chengshiwen commented on a diff in pull request #813: the update adds the documentation instructions for starting the documentation
Posted by GitBox <gi...@apache.org>.
chengshiwen commented on code in PR #813:
URL: https://github.com/apache/dolphinscheduler-website/pull/813#discussion_r923352281
##########
community/zh-cn/development/document.md:
##########
@@ -22,11 +22,13 @@ DolphinScheduler 网站由 [docsite](https://github.com/chengshiwen/docsite-ext)
1. 在根目录中运行 `npm install` 以安装依赖项。
-2. 在根目录下运行 `npm run start` 启动本地服务器，其将允许在 http://localhost:8080。
+2. 运行命令收集资源 2.1. 运行 export PROTOCOL_MODE=ssh 通过 SSH 协议而不是 HTTPS 协议 2.2 告诉 Git 克隆资源。 运行 ./scripts/prepare_docs.sh 准备所有相关资源，有关更多信息，您可以查看准备脚本的工作方式。
Review Comment:
Enclose `export PROTOCOL_MODE=ssh` and `./scripts/prepare_docs.sh` in backticks (`)
##########
community/en-us/development/document.md:
##########
@@ -22,11 +22,13 @@ Make sure that your node version is 10+, docsite does not yet support versions h
1. Run `npm install` in the root directory to install the dependencies.
-2. Run `npm run start` in the root directory to start a local server, you will see the website in 'http://localhost:8080'.
+2. Run commands to collect resources 2.1. Run export PROTOCOL_MODE=ssh tells Git clone resource via SSH protocol instead of HTTPS protocol 2.2. Run ./scripts/prepare_docs.sh prepare all related resources, for more information you could see how prepare script work.
Review Comment:
Enclose `export PROTOCOL_MODE=ssh` and `./scripts/prepare_docs.sh` in backticks (`) to denote a word as code like the [Build Website Locally](https://github.com/apache/dolphinscheduler-website/blob/master/README.md#build-website-locally). And add the link to [how prepare script work](https://github.com/apache/dolphinscheduler-website/blob/master/HOW_PREPARE_WOKR.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org