You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "Jarek Jarcec Cecho (Created) (JIRA)" <ji...@apache.org> on 2011/12/10 19:15:40 UTC
[jira] [Created] (FLUME-880) HDFSFormatterFactory is using ==
operator for String objects
HDFSFormatterFactory is using == operator for String objects
------------------------------------------------------------
Key: FLUME-880
URL: https://issues.apache.org/jira/browse/FLUME-880
Project: Flume
Issue Type: Bug
Components: Sinks+Sources
Affects Versions: NG alpha 3
Reporter: Jarek Jarcec Cecho
Assignee: Jarek Jarcec Cecho
Priority: Minor
Factory class HDFSFormatterFactory is using operator == for comparing String objects.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (FLUME-880) HDFSFormatterFactory is using ==
operator for String objects
Posted by "E. Sammer (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
E. Sammer closed FLUME-880.
---------------------------
> HDFSFormatterFactory is using == operator for String objects
> ------------------------------------------------------------
>
> Key: FLUME-880
> URL: https://issues.apache.org/jira/browse/FLUME-880
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: NG alpha 3
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Priority: Minor
> Fix For: NG alpha 3
>
> Attachments: FLUME-880.patch
>
>
> Factory class HDFSFormatterFactory is using operator == for comparing String objects.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-880) HDFSFormatterFactory is using ==
operator for String objects
Posted by "E. Sammer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
E. Sammer updated FLUME-880:
----------------------------
Fix Version/s: NG alpha 3
> HDFSFormatterFactory is using == operator for String objects
> ------------------------------------------------------------
>
> Key: FLUME-880
> URL: https://issues.apache.org/jira/browse/FLUME-880
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: NG alpha 3
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Priority: Minor
> Fix For: NG alpha 3
>
> Attachments: FLUME-880.patch
>
>
> Factory class HDFSFormatterFactory is using operator == for comparing String objects.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-880) HDFSFormatterFactory is using ==
operator for String objects
Posted by "Jarek Jarcec Cecho (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jarek Jarcec Cecho updated FLUME-880:
-------------------------------------
Status: Patch Available (was: Open)
> HDFSFormatterFactory is using == operator for String objects
> ------------------------------------------------------------
>
> Key: FLUME-880
> URL: https://issues.apache.org/jira/browse/FLUME-880
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: NG alpha 3
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Priority: Minor
> Attachments: FLUME-880.patch
>
>
> Factory class HDFSFormatterFactory is using operator == for comparing String objects.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-880) HDFSFormatterFactory is using ==
operator for String objects
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173918#comment-13173918 ]
Hudson commented on FLUME-880:
------------------------------
Integrated in flume-728 #78 (See [https://builds.apache.org/job/flume-728/78/])
FLUME-880: HDFSFormatterFactory is using == operator for String objects
(Jarek Jarcec Cecho via E. Sammer)
esammer : http://svn.apache.org/viewvc/?view=rev&rev=1221626
Files :
* /incubator/flume/branches/flume-728/flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSFormatterFactory.java
> HDFSFormatterFactory is using == operator for String objects
> ------------------------------------------------------------
>
> Key: FLUME-880
> URL: https://issues.apache.org/jira/browse/FLUME-880
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: NG alpha 3
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Priority: Minor
> Fix For: NG alpha 3
>
> Attachments: FLUME-880.patch
>
>
> Factory class HDFSFormatterFactory is using operator == for comparing String objects.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-880) HDFSFormatterFactory is using ==
operator for String objects
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13169134#comment-13169134 ]
jiraposter@reviews.apache.org commented on FLUME-880:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3145/#review3903
-----------------------------------------------------------
Ship it!
- Prasad
On 2011-12-10 18:18:47, Jarek Cecho wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3145/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-10 18:18:47)
bq.
bq.
bq. Review request for Flume and Eric Sammer.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. I've just changed operator == to method call equalsIgnoreCase().
bq.
bq.
bq. This addresses bug FLUME-880.
bq. https://issues.apache.org/jira/browse/FLUME-880
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /branches/flume-728/flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSFormatterFactory.java 1212827
bq.
bq. Diff: https://reviews.apache.org/r/3145/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. I've test it on my testing cluster. No formal test cases were added.
bq.
bq.
bq. Thanks,
bq.
bq. Jarek
bq.
bq.
> HDFSFormatterFactory is using == operator for String objects
> ------------------------------------------------------------
>
> Key: FLUME-880
> URL: https://issues.apache.org/jira/browse/FLUME-880
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: NG alpha 3
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Priority: Minor
>
> Factory class HDFSFormatterFactory is using operator == for comparing String objects.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-880) HDFSFormatterFactory is using ==
operator for String objects
Posted by "E. Sammer (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173877#comment-13173877 ]
E. Sammer commented on FLUME-880:
---------------------------------
I just noticed the review of this is closed as ship it but it hasn't been committed. I'll commit this one now.
> HDFSFormatterFactory is using == operator for String objects
> ------------------------------------------------------------
>
> Key: FLUME-880
> URL: https://issues.apache.org/jira/browse/FLUME-880
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: NG alpha 3
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Priority: Minor
> Attachments: FLUME-880.patch
>
>
> Factory class HDFSFormatterFactory is using operator == for comparing String objects.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-880) HDFSFormatterFactory is using ==
operator for String objects
Posted by "Jarek Jarcec Cecho (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jarek Jarcec Cecho updated FLUME-880:
-------------------------------------
Attachment: FLUME-880.patch
I've just changed operator == to method call equalsIgnoreCase().
> HDFSFormatterFactory is using == operator for String objects
> ------------------------------------------------------------
>
> Key: FLUME-880
> URL: https://issues.apache.org/jira/browse/FLUME-880
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: NG alpha 3
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Priority: Minor
> Attachments: FLUME-880.patch
>
>
> Factory class HDFSFormatterFactory is using operator == for comparing String objects.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-880) HDFSFormatterFactory is using ==
operator for String objects
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166919#comment-13166919 ]
jiraposter@reviews.apache.org commented on FLUME-880:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3145/
-----------------------------------------------------------
Review request for Flume and Eric Sammer.
Summary
-------
I've just changed operator == to method call equalsIgnoreCase().
This addresses bug FLUME-880.
https://issues.apache.org/jira/browse/FLUME-880
Diffs
-----
/branches/flume-728/flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSFormatterFactory.java 1212827
Diff: https://reviews.apache.org/r/3145/diff
Testing
-------
I've test it on my testing cluster. No formal test cases were added.
Thanks,
Jarek
> HDFSFormatterFactory is using == operator for String objects
> ------------------------------------------------------------
>
> Key: FLUME-880
> URL: https://issues.apache.org/jira/browse/FLUME-880
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: NG alpha 3
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Priority: Minor
>
> Factory class HDFSFormatterFactory is using operator == for comparing String objects.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-880) HDFSFormatterFactory is using ==
operator for String objects
Posted by "E. Sammer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
E. Sammer updated FLUME-880:
----------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed to branch flume-728.
Thanks Jarek!
> HDFSFormatterFactory is using == operator for String objects
> ------------------------------------------------------------
>
> Key: FLUME-880
> URL: https://issues.apache.org/jira/browse/FLUME-880
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: NG alpha 3
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Priority: Minor
> Attachments: FLUME-880.patch
>
>
> Factory class HDFSFormatterFactory is using operator == for comparing String objects.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira