[GitHub] [hive] amanraj2520 commented on pull request #4004: HIVE-27008: Partial cherry-pick of HIVE-20718 Add perf cli driver with constraints

["amanraj2520 (via GitHub)" <gi...@apache.org>]

amanraj2520 commented on PR #4004:
URL: https://github.com/apache/hive/pull/4004#issuecomment-1432917247

   @zabetak @abstractdog @cnauroth This is a slightly complicated fix for the current_date_timestamp.q test. The issue was a parsing issue in this test case where "explain cbo select current_timestamp() from alltypesorc" was not able to parse. Failure link : http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-4020/1/tests. In my local cherry picking this commit made sure that Hive was able to parse this. Now that test failed due to some assertion error which I fixed in this commit 8d1899e57e67b5b0fe06 . Now I need your suggestion :
   1. HIVE-20718 has a lot of merge conflicts mainly with HIVE-17040. For now in this PR I have made the test case scenario work with the minimalist changes I could cherry pick from HIVE-20718 (note I did not cherry pick HIVE-17040 in this PR). But there are some more changes that need to be included. Should we go ahead with this?
   2. Second approach can be cherry picking HIVE-17040 and then cherry picking HIVE-20718. Not sure how many merge conflicts will come in this but I will raise another PR for both these changes combined. I prefer this approach but that would mean creating two tickets or should I cherry pick them in one?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org