You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@plc4x.apache.org by GitBox <gi...@apache.org> on 2021/04/11 11:46:16 UTC
[GitHub] [plc4x] hutcheb opened a new pull request #237: Fix/modbus string
hutcheb opened a new pull request #237:
URL: https://github.com/apache/plc4x/pull/237
Java implementation for modbus strings using the format 400001:STRING(6)[3]
(6) is the string length
[3] is how many strings to read.
C and Go would need to be updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [plc4x] chrisdutz commented on pull request #237: Fix/modbus string
Posted by GitBox <gi...@apache.org>.
chrisdutz commented on pull request #237:
URL: https://github.com/apache/plc4x/pull/237#issuecomment-890828629
Hi Ben ... what's the status of this PR?
And do I understand it correctly, that this applies the same logic as with S7 for Modbus?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [plc4x] chrisdutz commented on pull request #237: Fix/modbus string
Posted by GitBox <gi...@apache.org>.
chrisdutz commented on pull request #237:
URL: https://github.com/apache/plc4x/pull/237#issuecomment-890857771
I think it's ok to not have 100% parity between all ... after all the Go KNX can do way more than the Java KNX ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [plc4x] chrisdutz commented on pull request #237: Fix/modbus string
Posted by GitBox <gi...@apache.org>.
chrisdutz commented on pull request #237:
URL: https://github.com/apache/plc4x/pull/237#issuecomment-890867145
I think I never really implemented String reading in go (or in C or in Java) ... so if the code generation produces something that compiles, I woudln't have any pain merging it. Do people read Strings in Modbus anyway? It definitely sounds totally inefficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [plc4x] chrisdutz commented on pull request #237: Fix/modbus string
Posted by GitBox <gi...@apache.org>.
chrisdutz commented on pull request #237:
URL: https://github.com/apache/plc4x/pull/237#issuecomment-890858354
You could just create two Jira issues for Go and C. Then just merge it (and add a comment to the RELEASE_NOTES) and be done with it ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [plc4x] hutcheb commented on pull request #237: Fix/modbus string
Posted by GitBox <gi...@apache.org>.
hutcheb commented on pull request #237:
URL: https://github.com/apache/plc4x/pull/237#issuecomment-890870669
That's the other thing, I can guarantee that there's not going to be a standard way of representing strings across PLCs.
I can't see it as being any more inefficient than reading other data types, you can read 240 odd bytes per request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [plc4x] hutcheb commented on pull request #237: Fix/modbus string
Posted by GitBox <gi...@apache.org>.
hutcheb commented on pull request #237:
URL: https://github.com/apache/plc4x/pull/237#issuecomment-890863776
There's a few changes in the mspec which causes a few issues in the other languages. I think at the moment we should at least be able to read strings in the other languages, we'd probably lose that if I hacked it together to be able to merge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [plc4x] hutcheb commented on pull request #237: Fix/modbus string
Posted by GitBox <gi...@apache.org>.
hutcheb commented on pull request #237:
URL: https://github.com/apache/plc4x/pull/237#issuecomment-890855376
Yes it applies the same principle as the S7 String logic. It ended up being more work than I was anticipating, but for Java it works. I haven't looked at C and Go though which is why it is still here.
I probably won't end up updating C and Go as there doesn't seem to be interest in it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org