You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Adam B (JIRA)" <ji...@apache.org> on 2015/04/21 00:33:58 UTC

[jira] [Resolved] (MESOS-2351) Enable label and environment decorators (hooks) to remove label and environment entries

     [ https://issues.apache.org/jira/browse/MESOS-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam B resolved MESOS-2351.
---------------------------
       Resolution: Fixed
    Fix Version/s: 0.23.0

commit 01ee1e504dec5cb65d2ae208fb01f28b2c93719f
Author: Niklas Nielsen <ni...@qni.dk>
Date:   Mon Apr 20 14:38:33 2015 -0700

    Fixed comment for remove executor hook.
    
    Review: https://reviews.apache.org/r/31017

commit 66cebd3fd7666747eb5d7c7ffd31208c94d5b7da
Author: Niklas Nielsen <ni...@qni.dk>
Date:   Mon Apr 20 14:37:37 2015 -0700

    Refactored VerifyMasterLaunchTaskHook to _not_ use command executor.
    
    Review: https://reviews.apache.org/r/32948

commit e2d6c86b8af2ff28a8591d9c8a2dbb2568c779d3
Author: Niklas Nielsen <ni...@qni.dk>
Date:   Mon Apr 20 14:37:19 2015 -0700

    Added slave run task hook tests.
    
    Review: https://reviews.apache.org/r/31028

commit 8dd1bb1213ac3f69fdcd5cbc35599fea49272b14
Author: Niklas Nielsen <ni...@qni.dk>
Date:   Mon Apr 20 14:36:40 2015 -0700

    Added slave run task decorator.
    
    Added decorator which gets invoked on start of runTask() sequence in the
    slave.
    
    Review: https://reviews.apache.org/r/31016

commit a454fc50a8304453d436021ff36742a6af6d8798
Author: Niklas Nielsen <ni...@qni.dk>
Date:   Mon Apr 20 14:36:28 2015 -0700

    Enabled environment decorator to override.
    
    Review: https://reviews.apache.org/r/30962

commit a090e9dc7698ecfe5da51826c1aa2e5163966272
Author: Niklas Nielsen <ni...@qni.dk>
Date:   Mon Apr 20 14:36:14 2015 -0700

    Enabled label decorator to override.
    
    Review: https://reviews.apache.org/r/30961

> Enable label and environment decorators (hooks) to remove label and environment entries
> ---------------------------------------------------------------------------------------
>
>                 Key: MESOS-2351
>                 URL: https://issues.apache.org/jira/browse/MESOS-2351
>             Project: Mesos
>          Issue Type: Task
>            Reporter: Niklas Quarfot Nielsen
>            Assignee: Niklas Quarfot Nielsen
>             Fix For: 0.23.0
>
>
> We need to change the semantics of decorators to be able to not only add labels and environment variables, but also remove them.
> The change is fairly small. The hook manager (and call site) use CopyFrom instead of MergeFrom and hook implementors pass on the labels and environment from task and executor commands respectively.
> In the future, we can tag labels such that only labels belonging to a hook type (across master and slave) can be inspected and changed. For now, the active hooks are selected by the operator and therefore be trusted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)