[GitHub] [pulsar] nicoloboschi commented on a change in pull request #14508: [flaky-tests] AdminApiSchemaTest#testSchemaInfoApi

[GitBox <gi...@apache.org>]

nicoloboschi commented on a change in pull request #14508:
URL: https://github.com/apache/pulsar/pull/14508#discussion_r816974088



##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/schema/SchemaTest.java
##########
@@ -708,7 +709,7 @@ public void testNullKeyValueProperty() throws PulsarAdminException, PulsarClient
         map.put(null, "value"); // null key is not allowed for JSON, it's only for test here
 
         // leave INT32 instance unchanged
-        final Schema<Integer> integerSchema = Schema.INT32.clone();
+        final Schema<Integer> integerSchema = DefaultImplementation.getDefaultImplementation().newIntSchema();

Review comment:
       @michaeljmarshall good catch! you're right
   I think this issue can be just fixed as @eolivelli suggested, using a JSON schema. The type of the schema is not relevant for test itself.
   
   I agree that the `clone()` method return `this` because probably the intention was to keep it immutable. 
   Moving the getter to return an immutable map may be the right solution, even if it can be considered breaking change because can cause runtime error while upgrading the client
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org