You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/12/06 14:25:20 UTC
[GitHub] [incubator-devlake] warren830 opened a new pull request, #3868: refactor(github): divide making scopes and making plans
warren830 opened a new pull request, #3868:
URL: https://github.com/apache/incubator-devlake/pull/3868
### Summary
1. divide making scopes and making plans to two funcs
2. refactor makePlan to contain for iteration, and modify unit test
### Does this close any open issues?
relate to #3486
### Screenshots
Include any relevant screenshots here.
### Other Information
Any other information that is important to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 commented on a diff in pull request #3868: refactor(github): divide making scopes and making plans
Posted by GitBox <gi...@apache.org>.
warren830 commented on code in PR #3868:
URL: https://github.com/apache/incubator-devlake/pull/3868#discussion_r1041674229
##########
plugins/github/api/blueprint_V200_test.go:
##########
@@ -37,6 +37,28 @@ import (
"time"
)
+var testGithubRepo = &models.GithubRepo{
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on a diff in pull request #3868: refactor(github): divide making scopes and making plans
Posted by GitBox <gi...@apache.org>.
klesh commented on code in PR #3868:
URL: https://github.com/apache/incubator-devlake/pull/3868#discussion_r1041050303
##########
plugins/github/api/blueprint_V200_test.go:
##########
@@ -37,6 +37,28 @@ import (
"time"
)
+var testGithubRepo = &models.GithubRepo{
Review Comment:
no global variable for unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh merged pull request #3868: refactor(github): divide making scopes and making plans
Posted by GitBox <gi...@apache.org>.
likyh merged PR #3868:
URL: https://github.com/apache/incubator-devlake/pull/3868
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org