You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sowmya Krishnan <so...@citrix.com> on 2013/08/18 09:30:54 UTC

Review Request 13633: CLOUDSTACK-3927, CLOUDSTACK-3928 Fix to add/remove NS devices in setupClass/tearDownClass

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13633/
-----------------------------------------------------------

Review request for cloudstack and Prasanna Santhanam.


Bugs: CLOUDSTACK-3927 and CLOUDSTACK-3928


Repository: cloudstack-git


Description
-------

Fix to add NS device in setupClass and remove in tearDown
Added a common method to perform these in common.add_netscaler()
Also fixes few account object issues in netscaler_configs.


Diffs
-----


Diff: https://reviews.apache.org/r/13633/diff/


Testing
-------

Tested scripts locally.


File Attachments
----------------

Patch
  https://reviews.apache.org/media/uploaded/files/2013/08/18/0001-CLOUDSTACK-3927-CLOUDSTACK-3928-Fix-NS-scripts-to-ad_1.patch


Thanks,

Sowmya Krishnan


Re: Review Request 13633: CLOUDSTACK-3927, CLOUDSTACK-3928 Fix to add/remove NS devices in setupClass/tearDownClass

Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13633/#review25339
-----------------------------------------------------------


discarded for https://reviews.apache.org/r/13680/

- Prasanna Santhanam


On Aug. 18, 2013, 7:30 a.m., Sowmya Krishnan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13633/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2013, 7:30 a.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-3927 and CLOUDSTACK-3928
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Fix to add NS device in setupClass and remove in tearDown
> Added a common method to perform these in common.add_netscaler()
> Also fixes few account object issues in netscaler_configs.
> 
> 
> Diffs
> -----
> 
> 
> Diff: https://reviews.apache.org/r/13633/diff/
> 
> 
> Testing
> -------
> 
> Tested scripts locally.
> 
> 
> File Attachments
> ----------------
> 
> Patch
>   https://reviews.apache.org/media/uploaded/files/2013/08/18/0001-CLOUDSTACK-3927-CLOUDSTACK-3928-Fix-NS-scripts-to-ad_1.patch
> 
> 
> Thanks,
> 
> Sowmya Krishnan
> 
>