You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Wes McKinney (Jira)" <ji...@apache.org> on 2020/05/25 14:00:00 UTC

[jira] [Updated] (ARROW-8933) [C++] Reduce generated code in vector_hash.cc

     [ https://issues.apache.org/jira/browse/ARROW-8933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wes McKinney updated ARROW-8933:
--------------------------------
    Description: 
Since hashing doesn't need to know about logical types, we can do the following:

* Use same generated code for both BinaryType and StringType (and LargeBinary/LargeString)
* Use same generated code for primitive types having the same byte width

These two changes should reduce binary size and improve compilation speed

  was:
Since hashing doesn't need to know about logical types, we can do the following:

* Use same generated code for both BinaryType and StringType
* Use same generated code for primitive types having the same byte width

These two changes should reduce binary size and improve compilation speed


> [C++] Reduce generated code in vector_hash.cc
> ---------------------------------------------
>
>                 Key: ARROW-8933
>                 URL: https://issues.apache.org/jira/browse/ARROW-8933
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Wes McKinney
>            Priority: Major
>             Fix For: 1.0.0
>
>
> Since hashing doesn't need to know about logical types, we can do the following:
> * Use same generated code for both BinaryType and StringType (and LargeBinary/LargeString)
> * Use same generated code for primitive types having the same byte width
> These two changes should reduce binary size and improve compilation speed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)