[GitHub] [hbase] YutSean commented on a diff in pull request #5260: HBASE-27766 Support steal job queue mode for read RPC queues of RWQue…

["YutSean (via GitHub)" <gi...@apache.org>]

YutSean commented on code in PR #5260:
URL: https://github.com/apache/hbase/pull/5260#discussion_r1265007096


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/StealRpcJobQueue.java:
##########
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.ipc;
+
+import java.util.Comparator;
+import org.apache.hadoop.hbase.util.StealJobQueue;
+import org.apache.yetus.audience.InterfaceAudience;
+
+@InterfaceAudience.Private
+public class StealRpcJobQueue extends StealJobQueue<CallRunner> {
+

Review Comment:
   Can we avoid using the priority queue? This makes the enqueuing & dequeuing method's time complexity from O(1) to O(logn). Further, can we involve fast path feature here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org