You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by cloud-fan <gi...@git.apache.org> on 2015/10/28 11:11:17 UTC

[GitHub] spark pull request: [SPARK-11370][SQL] fix a bug in GroupedIterato...

GitHub user cloud-fan opened a pull request:

    https://github.com/apache/spark/pull/9330

    [SPARK-11370][SQL] fix a bug in GroupedIterator and create unit test for it

    Before this PR, user has to consume the iterator of one group before process next group, or we will get into infinite loops.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloud-fan/spark group

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/9330.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #9330
    
----
commit a8cc6b51f40898e5d29f40def64079a5b6530574
Author: Wenchen Fan <we...@databricks.com>
Date:   2015-10-28T10:06:02Z

    fix a bug in GroupedIterator and create unit test for it

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11370][SQL] fix a bug in GroupedIterato...

Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9330#discussion_r43249575
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/GroupedIterator.scala ---
    @@ -96,46 +97,64 @@ class GroupedIterator private(
         ret
       }
     
    -  def fetchNextGroupIterator(): Boolean = {
    -    if (currentRow != null || input.hasNext) {
    -      val inputIterator = new Iterator[InternalRow] {
    -        // Return true if we have a row and it is in the current group, or if fetching a new row is
    -        // successful.
    -        def hasNext = {
    -          (currentRow != null && keyOrdering.compare(currentGroup, currentRow) == 0) ||
    -            fetchNextRowInGroup()
    -        }
    +  private def fetchNextGroupIterator(): Boolean = {
    +    assert(currentIterator eq null)
    +
    +    if (currentRow.eq(null) && input.hasNext) {
    +      currentRow = input.next()
    +    }
    +
    +    if (currentRow eq null) {
    +      // These is no data left, return false.
    +      false
    +    } else {
    +      // Skip to next group.
    +      while (input.hasNext && keyOrdering.compare(currentGroup, currentRow) == 0) {
    +        currentRow = input.next()
    +      }
    +
    +      if (keyOrdering.compare(currentGroup, currentRow) == 0) {
    +        // These is no more group. return false.
    --- End diff --
    
    nit: "there" or maybe more clearly "we are no longer in the current group, return false."


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11370][SQL] fix a bug in GroupedIterato...

Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on the pull request:

    https://github.com/apache/spark/pull/9330#issuecomment-152145164
  
    Thanks, merging to master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11370][SQL] fix a bug in GroupedIterato...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/9330#issuecomment-151891030
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11370][SQL] fix a bug in GroupedIterato...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/9330#issuecomment-152095675
  
    **[Test build #44560 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44560/consoleFull)** for PR 9330 at commit [`28f959c`](https://github.com/apache/spark/commit/28f959c07ca0fbe04305cd221cdb5f66d631fd8d).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11370][SQL] fix a bug in GroupedIterato...

Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9330#discussion_r43249449
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/GroupedIterator.scala ---
    @@ -83,11 +83,12 @@ class GroupedIterator private(
     
       /** Holds a copy of an input row that is in the current group. */
       var currentGroup = currentRow.copy()
    -  var currentIterator: Iterator[InternalRow] = null
    +
       assert(keyOrdering.compare(currentGroup, currentRow) == 0)
    --- End diff --
    
    This is the whole row, not just the key.  This allows us to do the equality check on the key columns only (which might short circuit) instead of doing a full projection on each row to extract the key columns.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11370][SQL] fix a bug in GroupedIterato...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/9330#issuecomment-151791918
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44518/
    Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11370][SQL] fix a bug in GroupedIterato...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/9330#issuecomment-151791915
  
    Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11370][SQL] fix a bug in GroupedIterato...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/9330#issuecomment-151791841
  
    **[Test build #44518 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44518/consoleFull)** for PR 9330 at commit [`a8cc6b5`](https://github.com/apache/spark/commit/a8cc6b51f40898e5d29f40def64079a5b6530574).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11370][SQL] fix a bug in GroupedIterato...

Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9330#discussion_r43249637
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/GroupedIteratorSuite.scala ---
    @@ -0,0 +1,65 @@
    +package org.apache.spark.sql.execution
    --- End diff --
    
    Need to add the apache header


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11370][SQL] fix a bug in GroupedIterato...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/9330#issuecomment-151890795
  
    **[Test build #44529 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44529/consoleFull)** for PR 9330 at commit [`9282e48`](https://github.com/apache/spark/commit/9282e488d58859a473e1413a611719829846971a).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11370][SQL] fix a bug in GroupedIterato...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/9330#issuecomment-151790510
  
     Merged build triggered.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11370][SQL] fix a bug in GroupedIterato...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/9330#issuecomment-151891032
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44529/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11370][SQL] fix a bug in GroupedIterato...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/9330#issuecomment-152072529
  
    Merged build started.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11370][SQL] fix a bug in GroupedIterato...

Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9330#discussion_r43236937
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/GroupedIterator.scala ---
    @@ -83,11 +83,12 @@ class GroupedIterator private(
     
       /** Holds a copy of an input row that is in the current group. */
       var currentGroup = currentRow.copy()
    -  var currentIterator: Iterator[InternalRow] = null
    +
       assert(keyOrdering.compare(currentGroup, currentRow) == 0)
    --- End diff --
    
    Looks like we only use `keyOrdering` to do equality check, why not just use `==`? The `currentGroup` and `currentRow` are from the same input, they must be both unsafe or safe, and `==` for `UnsafeRow` is faster than `keyOrdering.compare`.
    
    cc @marmbrus 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11370][SQL] fix a bug in GroupedIterato...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/9330


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11370][SQL] fix a bug in GroupedIterato...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/9330#issuecomment-151790549
  
    Merged build started.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11370][SQL] fix a bug in GroupedIterato...

Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9330#discussion_r43255063
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/GroupedIterator.scala ---
    @@ -83,11 +83,12 @@ class GroupedIterator private(
     
       /** Holds a copy of an input row that is in the current group. */
       var currentGroup = currentRow.copy()
    -  var currentIterator: Iterator[InternalRow] = null
    +
       assert(keyOrdering.compare(currentGroup, currentRow) == 0)
    --- End diff --
    
    Ah, sorry I missed it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11370][SQL] fix a bug in GroupedIterato...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/9330#issuecomment-151847822
  
    Merged build started.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11370][SQL] fix a bug in GroupedIterato...

Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9330#discussion_r43249474
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/GroupedIterator.scala ---
    @@ -83,11 +83,12 @@ class GroupedIterator private(
     
       /** Holds a copy of an input row that is in the current group. */
       var currentGroup = currentRow.copy()
    -  var currentIterator: Iterator[InternalRow] = null
    +
       assert(keyOrdering.compare(currentGroup, currentRow) == 0)
    +  var currentIterator = createGroupValuesIterator()
     
       // Return true if we already have the next iterator or fetching a new iterator is successful.
    -  def hasNext: Boolean = currentIterator != null || fetchNextGroupIterator
    +  def hasNext: Boolean = currentIterator.ne(null) || fetchNextGroupIterator
    --- End diff --
    
    I think these are the same, and I prefer the idiomatic version.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11370][SQL] fix a bug in GroupedIterato...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/9330#issuecomment-152073143
  
    **[Test build #44560 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44560/consoleFull)** for PR 9330 at commit [`28f959c`](https://github.com/apache/spark/commit/28f959c07ca0fbe04305cd221cdb5f66d631fd8d).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11370][SQL] fix a bug in GroupedIterato...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/9330#issuecomment-151791911
  
    **[Test build #44518 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44518/consoleFull)** for PR 9330 at commit [`a8cc6b5`](https://github.com/apache/spark/commit/a8cc6b51f40898e5d29f40def64079a5b6530574).
     * This patch **fails RAT tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11370][SQL] fix a bug in GroupedIterato...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/9330#issuecomment-152072522
  
     Merged build triggered.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11370][SQL] fix a bug in GroupedIterato...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/9330#issuecomment-151847794
  
     Merged build triggered.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11370][SQL] fix a bug in GroupedIterato...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/9330#issuecomment-152095757
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11370][SQL] fix a bug in GroupedIterato...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/9330#issuecomment-151850104
  
    **[Test build #44529 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44529/consoleFull)** for PR 9330 at commit [`9282e48`](https://github.com/apache/spark/commit/9282e488d58859a473e1413a611719829846971a).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11370][SQL] fix a bug in GroupedIterato...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/9330#issuecomment-152095758
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44560/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org