You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whirr.apache.org by "Tom White (JIRA)" <ji...@apache.org> on 2010/06/08 23:17:14 UTC
[jira] Created: (WHIRR-26) Allow script locations to be overridden
Allow script locations to be overridden
---------------------------------------
Key: WHIRR-26
URL: https://issues.apache.org/jira/browse/WHIRR-26
Project: Whirr
Issue Type: Improvement
Components: core
Reporter: Tom White
Priority: Blocker
Fix For: 0.1.0
Currently the script locations are hard-coded to an EC2 bucket. We should make this configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WHIRR-26) Allow script locations to be overridden
Posted by "Jeff Hammerbacher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-26?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeff Hammerbacher updated WHIRR-26:
-----------------------------------
Status: Patch Available (was: Open)
> Allow script locations to be overridden
> ---------------------------------------
>
> Key: WHIRR-26
> URL: https://issues.apache.org/jira/browse/WHIRR-26
> Project: Whirr
> Issue Type: Improvement
> Components: core
> Reporter: Tom White
> Assignee: Jeff Hammerbacher
> Priority: Blocker
> Fix For: 0.1.0
>
> Attachments: WHIRR-26.patch
>
>
> Currently the script locations are hard-coded to an EC2 bucket. We should make this configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WHIRR-26) Allow script locations to be overridden
Posted by "Jeff Hammerbacher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-26?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeff Hammerbacher reassigned WHIRR-26:
--------------------------------------
Assignee: Jeff Hammerbacher
> Allow script locations to be overridden
> ---------------------------------------
>
> Key: WHIRR-26
> URL: https://issues.apache.org/jira/browse/WHIRR-26
> Project: Whirr
> Issue Type: Improvement
> Components: core
> Reporter: Tom White
> Assignee: Jeff Hammerbacher
> Priority: Blocker
> Fix For: 0.1.0
>
>
> Currently the script locations are hard-coded to an EC2 bucket. We should make this configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WHIRR-26) Allow script locations to be overridden
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-26?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated WHIRR-26:
---------------------------
Status: Resolved (was: Patch Available)
Resolution: Fixed
+1 I moved the scripts to http://whirr.s3.amazonaws.com/ and ran the zookeeper test to manually verify this patch.
I've just committed this. Thanks, Jeff!
I shall write a unit test for RunUrlBuilder as a part of WHIRR-22.
> Allow script locations to be overridden
> ---------------------------------------
>
> Key: WHIRR-26
> URL: https://issues.apache.org/jira/browse/WHIRR-26
> Project: Whirr
> Issue Type: Improvement
> Components: core
> Reporter: Tom White
> Assignee: Jeff Hammerbacher
> Priority: Blocker
> Fix For: 0.1.0
>
> Attachments: WHIRR-26.patch
>
>
> Currently the script locations are hard-coded to an EC2 bucket. We should make this configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WHIRR-26) Allow script locations to be overridden
Posted by "Jeff Hammerbacher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-26?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeff Hammerbacher updated WHIRR-26:
-----------------------------------
Attachment: WHIRR-26.patch
The attached patch allows the user to set a Java system property called {{whirr.runurl.base}} which will be prepended to all "urls" submitted to RunUrlBuilder. Note that we now require that the protocol (http://) be specified for this prefix, as the java.net.URL constructor expects a protocol to be supplied even if runurl/wget do not require it; I could change to handle that case for the user as well, but it felt a bit magical to do two rounds of URL scrubbing.
There are currently no tests for Whirr core, so I did not add a test for this new behavior. Once there's a unit testing framework in place, I might just use it, but I don't feel comfortable adding the first test.
> Allow script locations to be overridden
> ---------------------------------------
>
> Key: WHIRR-26
> URL: https://issues.apache.org/jira/browse/WHIRR-26
> Project: Whirr
> Issue Type: Improvement
> Components: core
> Reporter: Tom White
> Assignee: Jeff Hammerbacher
> Priority: Blocker
> Fix For: 0.1.0
>
> Attachments: WHIRR-26.patch
>
>
> Currently the script locations are hard-coded to an EC2 bucket. We should make this configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WHIRR-26) Allow script locations to be
overridden
Posted by "Jeff Hammerbacher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-26?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12881478#action_12881478 ]
Jeff Hammerbacher commented on WHIRR-26:
----------------------------------------
I was able to successfully start a cluster, run a job, and bring it down with {{-Dwhirr.runurl.base=http://cloudera-tom.s3.amazonaws.com}}. Tom is going to move the scripts to the default S3 bucket of {{http://whirr.s3.amazonaws.com}} tonight.
> Allow script locations to be overridden
> ---------------------------------------
>
> Key: WHIRR-26
> URL: https://issues.apache.org/jira/browse/WHIRR-26
> Project: Whirr
> Issue Type: Improvement
> Components: core
> Reporter: Tom White
> Assignee: Jeff Hammerbacher
> Priority: Blocker
> Fix For: 0.1.0
>
> Attachments: WHIRR-26.patch
>
>
> Currently the script locations are hard-coded to an EC2 bucket. We should make this configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.