[GitHub] [incubator-superset] michellethomas opened a new pull request #7106: Use metric name instead of metric in filter box

[GitBox <gi...@apache.org>]

michellethomas opened a new pull request #7106: Use metric name instead of metric in filter box
URL: https://github.com/apache/incubator-superset/pull/7106
 
 
   Filter box charts break if they are using adhoc metrics, so changing viz.py to sort_values on metric name instead of metric. 
   
   Existing filter boxes could use adhoc metrics (because it was previously a metric control), so any charts migrated that previously used adhoc metrics would break. The new filter boxes currently don't have the ability to use adhoc metrics, but it should be added in the future. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org