You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "shunping (via GitHub)" <gi...@apache.org> on 2024/03/06 19:42:12 UTC
[PR] Fix pr 30455 [beam]
shunping opened a new pull request, #30546:
URL: https://github.com/apache/beam/pull/30546
PR #30455 has caused some internal test failure. We are going to skip the test if BigQueryWrapper cannot be imported.
(Internal bug id: 302004313)
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix internal test failure from PR-30455 [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #30546:
URL: https://github.com/apache/beam/pull/30546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix internal test failure from PR-30455 [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30546:
URL: https://github.com/apache/beam/pull/30546#issuecomment-1981828119
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @AnandInguva for label python.
R: @ahmedabu98 for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix internal test failure from PR-30455 [beam]
Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping commented on code in PR #30546:
URL: https://github.com/apache/beam/pull/30546#discussion_r1516533940
##########
sdks/python/apache_beam/io/gcp/bigquery_tools_test.py:
##########
@@ -224,9 +224,15 @@ def test_delete_dataset_retries_for_timeouts(self, patched_time_sleep):
self.assertTrue(client.datasets.Delete.called)
@mock.patch('time.sleep', return_value=None)
+ @mock.patch(
+ 'apitools.base.py.base_api._SkipGetCredentials', return_value=True)
@mock.patch('google.cloud._http.JSONConnection.http')
- def test_user_agent_insert_all(self, http_mock, patched_sleep):
- wrapper = beam.io.gcp.bigquery_tools.BigQueryWrapper()
+ def test_user_agent_insert_all(
+ self, http_mock, patched_skip_get_credentials, patched_sleep):
+ try:
Review Comment:
Ok. Looks like that google.cloud.bigquery is not accessible in the internal test environment. I just made some change on the code. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix internal test failure from PR-30455 [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #30546:
URL: https://github.com/apache/beam/pull/30546#discussion_r1515232397
##########
sdks/python/apache_beam/io/gcp/bigquery_tools_test.py:
##########
@@ -224,9 +224,15 @@ def test_delete_dataset_retries_for_timeouts(self, patched_time_sleep):
self.assertTrue(client.datasets.Delete.called)
@mock.patch('time.sleep', return_value=None)
+ @mock.patch(
+ 'apitools.base.py.base_api._SkipGetCredentials', return_value=True)
@mock.patch('google.cloud._http.JSONConnection.http')
- def test_user_agent_insert_all(self, http_mock, patched_sleep):
- wrapper = beam.io.gcp.bigquery_tools.BigQueryWrapper()
+ def test_user_agent_insert_all(
+ self, http_mock, patched_skip_get_credentials, patched_sleep):
+ try:
Review Comment:
This does not sounds a valid workaround. It's like error happens in a line and then we skip the test. If it is "it needs network access to get credential.", then we should skip the test when there isn't network access in the `@skipIf` annotation, and not inside the test
##########
sdks/python/apache_beam/io/gcp/bigquery_tools_test.py:
##########
@@ -224,9 +224,15 @@ def test_delete_dataset_retries_for_timeouts(self, patched_time_sleep):
self.assertTrue(client.datasets.Delete.called)
@mock.patch('time.sleep', return_value=None)
+ @mock.patch(
+ 'apitools.base.py.base_api._SkipGetCredentials', return_value=True)
@mock.patch('google.cloud._http.JSONConnection.http')
- def test_user_agent_insert_all(self, http_mock, patched_sleep):
- wrapper = beam.io.gcp.bigquery_tools.BigQueryWrapper()
+ def test_user_agent_insert_all(
+ self, http_mock, patched_skip_get_credentials, patched_sleep):
+ try:
Review Comment:
This does not sound a valid workaround. It's like error happens in a line and then we skip the test. If it is "it needs network access to get credential.", then we should skip the test when there isn't network access in the `@skipIf` annotation, and not inside the test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix internal test failure from PR-30455 [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #30546:
URL: https://github.com/apache/beam/pull/30546#discussion_r1515232397
##########
sdks/python/apache_beam/io/gcp/bigquery_tools_test.py:
##########
@@ -224,9 +224,15 @@ def test_delete_dataset_retries_for_timeouts(self, patched_time_sleep):
self.assertTrue(client.datasets.Delete.called)
@mock.patch('time.sleep', return_value=None)
+ @mock.patch(
+ 'apitools.base.py.base_api._SkipGetCredentials', return_value=True)
@mock.patch('google.cloud._http.JSONConnection.http')
- def test_user_agent_insert_all(self, http_mock, patched_sleep):
- wrapper = beam.io.gcp.bigquery_tools.BigQueryWrapper()
+ def test_user_agent_insert_all(
+ self, http_mock, patched_skip_get_credentials, patched_sleep):
+ try:
Review Comment:
This does not sounds a valid workaround. It's like error happens in a line and then we skip the test. If it is "it needs network access to get credential.", then we should skip the test when there isn't network access in the decorator, and not inside the test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org