You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@heron.apache.org by GitBox <gi...@apache.org> on 2022/03/25 15:12:35 UTC

[GitHub] [incubator-heron] windhamwong opened a new issue #3801: Renamed variable but not updating the js

windhamwong opened a new issue #3801:
URL: https://github.com/apache/incubator-heron/issues/3801


   https://github.com/apache/incubator-heron/blob/9cfc5c4785ba0c14d26dfbbf0fe1d6b477dd38a5/heron/tools/ui/resources/static/js/physical-plan.js#L55
   
   Looks like the code `containers[worker.stmgrId]` is invalid because the stmgr ID has been renamed to `worker.stmgr_id`.
   
   ![image](https://user-images.githubusercontent.com/677625/160147653-9667aaf9-db95-4b13-af67-9c7a0cd8048d.png)
   
   I am using `/pull/3779` based on master, but the PR has no change to the code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-heron] windhamwong edited a comment on issue #3801: Renamed variable but not updating the js

Posted by GitBox <gi...@apache.org>.
windhamwong edited a comment on issue #3801:
URL: https://github.com/apache/incubator-heron/issues/3801#issuecomment-1079134617


   Confirmed working if changing `stmgrId` to `stmgr_id`. See if anyone has the same issue, i have created PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-heron] nicknezis commented on issue #3801: Renamed variable but not updating the js

Posted by GitBox <gi...@apache.org>.
nicknezis commented on issue #3801:
URL: https://github.com/apache/incubator-heron/issues/3801#issuecomment-1079730261


   This is currently being worked in #3786 . Feel free to submit any pull requests to that branch as we resolve the issues. There were many more broken aspects when we updated the code to support the newer Python versions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org