You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "healchow (via GitHub)" <gi...@apache.org> on 2023/03/15 11:04:38 UTC

[GitHub] [inlong] healchow commented on a diff in pull request #7617: [INLONG-7616][Manager] Fix failed to obtain audit information

healchow commented on code in PR #7617:
URL: https://github.com/apache/inlong/pull/7617#discussion_r1136881342


##########
inlong-manager/manager-dao/src/main/resources/mappers/AuditBaseEntityMapper.xml:
##########
@@ -66,12 +66,8 @@
         <include refid="Base_Column_List"/>
         from audit_base
         <where>
-            <if test="type != null and type != ''">
-                and type = #{type, jdbcType=VARCHAR}
-            </if>
-            <if test="isSent != null and isSent != ''">
-                and is_sent = #{isSent,jdbcType=INTEGER}
-            </if>
+            and type = #{type, jdbcType=VARCHAR}

Review Comment:
   Is the first `and` necessary?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org