You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/07/19 08:49:05 UTC
[GitHub] [incubator-nuttx-apps] lukegluke opened a new pull request #808: system/cu: fix setting termios with parity
lukegluke opened a new pull request #808:
URL: https://github.com/apache/incubator-nuttx-apps/pull/808
Clear only the bits in `c_cflag` that will be set by cu.
Otherwise if even or odd parity is set all other bits of `c_cflag` will be cleared.
Including `CS8` default character size. And this will leads in the end to the error `EINVAL` in sanity checks on termios setting in `up_ioctl()` in stm32_serial:
https://github.com/apache/incubator-nuttx/blob/02a6966ad5de551a9f2adb0f97c21d404170c79b/arch/arm/src/stm32/stm32_serial.c#L2349-L2360
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #808: system/cu: fix setting termios with parity
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #808:
URL: https://github.com/apache/incubator-nuttx-apps/pull/808
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] lukegluke removed a comment on pull request #808: system/cu: fix setting termios with parity
Posted by GitBox <gi...@apache.org>.
lukegluke removed a comment on pull request #808:
URL: https://github.com/apache/incubator-nuttx-apps/pull/808#issuecomment-882372301
It was much easier to fix this here in web github, so can't amend previous commit with style fix. Please squash.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] lukegluke removed a comment on pull request #808: system/cu: fix setting termios with parity
Posted by GitBox <gi...@apache.org>.
lukegluke removed a comment on pull request #808:
URL: https://github.com/apache/incubator-nuttx-apps/pull/808#issuecomment-882372301
It was much easier to fix this here in web github, so can't amend previous commit with style fix. Please squash.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #808: system/cu: fix setting termios with parity
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #808:
URL: https://github.com/apache/incubator-nuttx-apps/pull/808
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] lukegluke commented on pull request #808: system/cu: fix setting termios with parity
Posted by GitBox <gi...@apache.org>.
lukegluke commented on pull request #808:
URL: https://github.com/apache/incubator-nuttx-apps/pull/808#issuecomment-882372301
It was much easier to fix this here in web github, so can't amend previous commit with style fix. Please squash.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] lukegluke commented on pull request #808: system/cu: fix setting termios with parity
Posted by GitBox <gi...@apache.org>.
lukegluke commented on pull request #808:
URL: https://github.com/apache/incubator-nuttx-apps/pull/808#issuecomment-882372301
It was much easier to fix this here in web github, so can't amend previous commit with style fix. Please squash.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org