You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Attila Csordas (Commented) (JIRA)" <ji...@apache.org> on 2011/11/18 00:13:51 UTC

[jira] [Commented] (GIRAPH-84) Simplify boolean expressions in BspRecordReader

    [ https://issues.apache.org/jira/browse/GIRAPH-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152438#comment-13152438 ] 

Attila Csordas commented on GIRAPH-84:
--------------------------------------

instead of this:
        if (seenRecord == true) {
            return 1f;
        }
        else {
            return 0f;
        }

can I write:

        if (seenRecord) return 1f;
        else return 0f;

?
                
> Simplify boolean expressions in BspRecordReader
> -----------------------------------------------
>
>                 Key: GIRAPH-84
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-84
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Jakob Homan
>            Assignee: Attila Csordas
>              Labels: newbie
>
> Twice in BspRecordReader boolean expressions are evaluated with == and can be simplified to just one liners or variable evaluation.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira