You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2015/10/20 22:50:11 UTC

Review Request 39494: Added libevent and ssl flags to config docs.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39494/
-----------------------------------------------------------

Review request for mesos, haosdent huang, Joris Van Remoortere, and Neil Conway.


Bugs: MESOS-3749
    https://issues.apache.org/jira/browse/MESOS-3749


Repository: mesos


Description
-------

Added libevent and ssl flags to config docs.


Diffs
-----

  docs/configuration.md c7d5da68a5cede7a8d57ccf94cebf8a10af2d9c6 

Diff: https://reviews.apache.org/r/39494/diff/


Testing
-------

Viewed in the Mesos Website Container: https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann

Re: Review Request 39494: Added libnl, libevent and ssl flags to config docs.

Posted by Greg Mann <gr...@mesosphere.io>.

> On Oct. 21, 2015, 2:23 a.m., haosdent huang wrote:
> > docs/configuration.md, line 1655
> > <https://reviews.apache.org/r/39494/diff/3/?file=1102108#file1102108line1655>
> >
> >     According the output of `../configure --help`, seems the document miss `--with-nl`. But I not sure should add it in this patch or a sperate patch.
> >     ```
> >     --with-nl=[DIR]         specify where to locate the libnl3 library (required
> >                               for network-isolator). [default: /usr]
> >     ```

Since it's a small change, I went ahead and added it into this review. Thanks, haosdent!


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39494/#review103340
-----------------------------------------------------------


On Oct. 21, 2015, 4:17 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39494/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2015, 4:17 p.m.)
> 
> 
> Review request for mesos, haosdent huang, Joris Van Remoortere, and Neil Conway.
> 
> 
> Bugs: MESOS-3749
>     https://issues.apache.org/jira/browse/MESOS-3749
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added libnl, libevent and ssl flags to config docs.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md c7d5da68a5cede7a8d57ccf94cebf8a10af2d9c6 
> 
> Diff: https://reviews.apache.org/r/39494/diff/
> 
> 
> Testing
> -------
> 
> Viewed in the Mesos Website Container: https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39494: Added libevent and ssl flags to config docs.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39494/#review103340
-----------------------------------------------------------



docs/configuration.md (line 1655)
<https://reviews.apache.org/r/39494/#comment161354>

    According the output of `../configure --help`, seems the document miss `--with-nl`. But I not sure should add it in this patch or a sperate patch.
    ```
    --with-nl=[DIR]         specify where to locate the libnl3 library (required
                              for network-isolator). [default: /usr]
    ```


- haosdent huang


On Oct. 20, 2015, 9:58 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39494/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2015, 9:58 p.m.)
> 
> 
> Review request for mesos, haosdent huang, Joris Van Remoortere, and Neil Conway.
> 
> 
> Bugs: MESOS-3749
>     https://issues.apache.org/jira/browse/MESOS-3749
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added libevent and ssl flags to config docs.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md c7d5da68a5cede7a8d57ccf94cebf8a10af2d9c6 
> 
> Diff: https://reviews.apache.org/r/39494/diff/
> 
> 
> Testing
> -------
> 
> Viewed in the Mesos Website Container: https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39494: Added libevent and ssl flags to config docs.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39494/#review103376
-----------------------------------------------------------


Patch looks great!

Reviews applied: [39494]

All tests passed.

- Mesos ReviewBot


On Oct. 20, 2015, 9:58 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39494/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2015, 9:58 p.m.)
> 
> 
> Review request for mesos, haosdent huang, Joris Van Remoortere, and Neil Conway.
> 
> 
> Bugs: MESOS-3749
>     https://issues.apache.org/jira/browse/MESOS-3749
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added libevent and ssl flags to config docs.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md c7d5da68a5cede7a8d57ccf94cebf8a10af2d9c6 
> 
> Diff: https://reviews.apache.org/r/39494/diff/
> 
> 
> Testing
> -------
> 
> Viewed in the Mesos Website Container: https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39494: Added libevent and ssl flags to config docs.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39494/#review103341
-----------------------------------------------------------

Ship it!


Ship It!

- haosdent huang


On Oct. 20, 2015, 9:58 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39494/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2015, 9:58 p.m.)
> 
> 
> Review request for mesos, haosdent huang, Joris Van Remoortere, and Neil Conway.
> 
> 
> Bugs: MESOS-3749
>     https://issues.apache.org/jira/browse/MESOS-3749
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added libevent and ssl flags to config docs.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md c7d5da68a5cede7a8d57ccf94cebf8a10af2d9c6 
> 
> Diff: https://reviews.apache.org/r/39494/diff/
> 
> 
> Testing
> -------
> 
> Viewed in the Mesos Website Container: https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39494: Added libevent and ssl flags to config docs.

Posted by Gilbert Song <gi...@mesoshere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39494/#review103319
-----------------------------------------------------------

Ship it!


Ship It!

- Gilbert Song


On Oct. 20, 2015, 2:58 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39494/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2015, 2:58 p.m.)
> 
> 
> Review request for mesos, haosdent huang, Joris Van Remoortere, and Neil Conway.
> 
> 
> Bugs: MESOS-3749
>     https://issues.apache.org/jira/browse/MESOS-3749
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added libevent and ssl flags to config docs.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md c7d5da68a5cede7a8d57ccf94cebf8a10af2d9c6 
> 
> Diff: https://reviews.apache.org/r/39494/diff/
> 
> 
> Testing
> -------
> 
> Viewed in the Mesos Website Container: https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39494: Added libnl, libevent and ssl flags to config docs.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39494/#review103429
-----------------------------------------------------------


Patch looks great!

Reviews applied: [39494]

All tests passed.

- Mesos ReviewBot


On Oct. 21, 2015, 4:17 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39494/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2015, 4:17 p.m.)
> 
> 
> Review request for mesos, haosdent huang, Joris Van Remoortere, and Neil Conway.
> 
> 
> Bugs: MESOS-3749
>     https://issues.apache.org/jira/browse/MESOS-3749
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added libnl, libevent and ssl flags to config docs.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md c7d5da68a5cede7a8d57ccf94cebf8a10af2d9c6 
> 
> Diff: https://reviews.apache.org/r/39494/diff/
> 
> 
> Testing
> -------
> 
> Viewed in the Mesos Website Container: https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39494: Added libnl, libevent and ssl flags to config docs.

Posted by Greg Mann <gr...@mesosphere.io>.

> On Oct. 21, 2015, 5:22 p.m., Cong Wang wrote:
> > docs/configuration.md, line 1915
> > <https://reviews.apache.org/r/39494/diff/4/?file=1102431#file1102431line1915>
> >
> >     Like what you do for libevent, it would be nicer if you can add a URL to libnl3 too, but this is not a big deal...

Good call, added it. Thanks Cong!


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39494/#review103434
-----------------------------------------------------------


On Oct. 21, 2015, 5:28 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39494/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2015, 5:28 p.m.)
> 
> 
> Review request for mesos, haosdent huang, Joris Van Remoortere, and Neil Conway.
> 
> 
> Bugs: MESOS-3749
>     https://issues.apache.org/jira/browse/MESOS-3749
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added libnl, libevent and ssl flags to config docs.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md c7d5da68a5cede7a8d57ccf94cebf8a10af2d9c6 
> 
> Diff: https://reviews.apache.org/r/39494/diff/
> 
> 
> Testing
> -------
> 
> Viewed in the Mesos Website Container: https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39494: Added libnl, libevent and ssl flags to config docs.

Posted by Cong Wang <cw...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39494/#review103434
-----------------------------------------------------------



docs/configuration.md (line 1915)
<https://reviews.apache.org/r/39494/#comment161489>

    Like what you do for libevent, it would be nicer if you can add a URL to libnl3 too, but this is not a big deal...


- Cong Wang


On Oct. 21, 2015, 4:17 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39494/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2015, 4:17 p.m.)
> 
> 
> Review request for mesos, haosdent huang, Joris Van Remoortere, and Neil Conway.
> 
> 
> Bugs: MESOS-3749
>     https://issues.apache.org/jira/browse/MESOS-3749
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added libnl, libevent and ssl flags to config docs.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md c7d5da68a5cede7a8d57ccf94cebf8a10af2d9c6 
> 
> Diff: https://reviews.apache.org/r/39494/diff/
> 
> 
> Testing
> -------
> 
> Viewed in the Mesos Website Container: https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39494: Added libnl, libevent and ssl flags to config docs.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39494/#review103453
-----------------------------------------------------------


Patch looks great!

Reviews applied: [39494]

All tests passed.

- Mesos ReviewBot


On Oct. 21, 2015, 5:28 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39494/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2015, 5:28 p.m.)
> 
> 
> Review request for mesos, haosdent huang, Joris Van Remoortere, and Neil Conway.
> 
> 
> Bugs: MESOS-3749
>     https://issues.apache.org/jira/browse/MESOS-3749
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added libnl, libevent and ssl flags to config docs.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md c7d5da68a5cede7a8d57ccf94cebf8a10af2d9c6 
> 
> Diff: https://reviews.apache.org/r/39494/diff/
> 
> 
> Testing
> -------
> 
> Viewed in the Mesos Website Container: https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39494: Added libnl, libevent and ssl flags to config docs.

Posted by Cong Wang <cw...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39494/#review103436
-----------------------------------------------------------

Ship it!


Ship It!

- Cong Wang


On Oct. 21, 2015, 5:28 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39494/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2015, 5:28 p.m.)
> 
> 
> Review request for mesos, haosdent huang, Joris Van Remoortere, and Neil Conway.
> 
> 
> Bugs: MESOS-3749
>     https://issues.apache.org/jira/browse/MESOS-3749
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added libnl, libevent and ssl flags to config docs.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md c7d5da68a5cede7a8d57ccf94cebf8a10af2d9c6 
> 
> Diff: https://reviews.apache.org/r/39494/diff/
> 
> 
> Testing
> -------
> 
> Viewed in the Mesos Website Container: https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39494: Added libnl, libevent and ssl flags to config docs.

Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39494/#review104019
-----------------------------------------------------------

Ship it!


Thanks for taking this on Greg!
Greg will follow up with some patches to make the style in this document consistent. We've kept it locally consistent for now.


docs/configuration.md (lines 1659 - 1660)
<https://reviews.apache.org/r/39494/#comment162210>

    `the libevent development package is required`?



docs/configuration.md (line 1660)
<https://reviews.apache.org/r/39494/#comment162209>

    `version 2+`



docs/configuration.md (line 1670)
<https://reviews.apache.org/r/39494/#comment162211>

    `--enable-libevent is currently required`?



docs/configuration.md (line 1888)
<https://reviews.apache.org/r/39494/#comment162217>

    It seems like there are 2 forms of this flag / message:
    `--with-libevent[=DIR]` and ``--with-libevent=[=DIR]``
    
    It seems like there are 2 forms of this message:
    ```
    excludes building and using the bundled XXX package in lieu of an installed version at a location prefixed by the given path
    ```
    and what you have.
    Feel free to make them totally consistent with a new review.
    
    Here and below.


- Joris Van Remoortere


On Oct. 21, 2015, 5:28 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39494/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2015, 5:28 p.m.)
> 
> 
> Review request for mesos, haosdent huang, Joris Van Remoortere, and Neil Conway.
> 
> 
> Bugs: MESOS-3749
>     https://issues.apache.org/jira/browse/MESOS-3749
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added libnl, libevent and ssl flags to config docs.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md c7d5da68a5cede7a8d57ccf94cebf8a10af2d9c6 
> 
> Diff: https://reviews.apache.org/r/39494/diff/
> 
> 
> Testing
> -------
> 
> Viewed in the Mesos Website Container: https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39494: Added libnl, libevent and ssl flags to config docs.

Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39494/
-----------------------------------------------------------

(Updated Oct. 21, 2015, 5:28 p.m.)


Review request for mesos, haosdent huang, Joris Van Remoortere, and Neil Conway.


Changes
-------

Addressed comment.


Bugs: MESOS-3749
    https://issues.apache.org/jira/browse/MESOS-3749


Repository: mesos


Description
-------

Added libnl, libevent and ssl flags to config docs.


Diffs (updated)
-----

  docs/configuration.md c7d5da68a5cede7a8d57ccf94cebf8a10af2d9c6 

Diff: https://reviews.apache.org/r/39494/diff/


Testing
-------

Viewed in the Mesos Website Container: https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann

Re: Review Request 39494: Added libnl, libevent and ssl flags to config docs.

Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39494/
-----------------------------------------------------------

(Updated Oct. 21, 2015, 4:17 p.m.)


Review request for mesos, haosdent huang, Joris Van Remoortere, and Neil Conway.


Changes
-------

Added --with-nl flag to config docs.


Summary (updated)
-----------------

Added libnl, libevent and ssl flags to config docs.


Bugs: MESOS-3749
    https://issues.apache.org/jira/browse/MESOS-3749


Repository: mesos


Description (updated)
-------

Added libnl, libevent and ssl flags to config docs.


Diffs (updated)
-----

  docs/configuration.md c7d5da68a5cede7a8d57ccf94cebf8a10af2d9c6 

Diff: https://reviews.apache.org/r/39494/diff/


Testing
-------

Viewed in the Mesos Website Container: https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann

Re: Review Request 39494: Added libevent and ssl flags to config docs.

Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39494/
-----------------------------------------------------------

(Updated Oct. 20, 2015, 9:58 p.m.)


Review request for mesos, haosdent huang, Joris Van Remoortere, and Neil Conway.


Changes
-------

Added --with-ssl flag.


Bugs: MESOS-3749
    https://issues.apache.org/jira/browse/MESOS-3749


Repository: mesos


Description
-------

Added libevent and ssl flags to config docs.


Diffs (updated)
-----

  docs/configuration.md c7d5da68a5cede7a8d57ccf94cebf8a10af2d9c6 

Diff: https://reviews.apache.org/r/39494/diff/


Testing
-------

Viewed in the Mesos Website Container: https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann

Re: Review Request 39494: Added libevent and ssl flags to config docs.

Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39494/
-----------------------------------------------------------

(Updated Oct. 20, 2015, 9:55 p.m.)


Review request for mesos, haosdent huang, Joris Van Remoortere, and Neil Conway.


Changes
-------

Removed recommended version, added --with-libevent=DIR flag.


Bugs: MESOS-3749
    https://issues.apache.org/jira/browse/MESOS-3749


Repository: mesos


Description
-------

Added libevent and ssl flags to config docs.


Diffs (updated)
-----

  docs/configuration.md c7d5da68a5cede7a8d57ccf94cebf8a10af2d9c6 

Diff: https://reviews.apache.org/r/39494/diff/


Testing
-------

Viewed in the Mesos Website Container: https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann

Re: Review Request 39494: Added libevent and ssl flags to config docs.

Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39494/#review103306
-----------------------------------------------------------

Ship it!


Ship It!


docs/configuration.md (line 1661)
<https://reviews.apache.org/r/39494/#comment161286>

    I'd remove the "recommended" version, unless we really have a version dependency: this will require updating and/or become out of date.


- Neil Conway


On Oct. 20, 2015, 8:50 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39494/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2015, 8:50 p.m.)
> 
> 
> Review request for mesos, haosdent huang, Joris Van Remoortere, and Neil Conway.
> 
> 
> Bugs: MESOS-3749
>     https://issues.apache.org/jira/browse/MESOS-3749
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added libevent and ssl flags to config docs.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md c7d5da68a5cede7a8d57ccf94cebf8a10af2d9c6 
> 
> Diff: https://reviews.apache.org/r/39494/diff/
> 
> 
> Testing
> -------
> 
> Viewed in the Mesos Website Container: https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39494: Added libevent and ssl flags to config docs.

Posted by haosdent huang <ha...@gmail.com>.

> On Oct. 20, 2015, 9:55 p.m., Joseph Wu wrote:
> > Not really related, but do you know if markdown-style tables are supported here?
> 
> Greg Mann wrote:
>     Hmmm... not sure.

I seem the document [middleman](https://middlemanapp.com/basics/template_engine_options/), seems should support github style markdown table, because in config.rb has already add this:
```
set :markdown, :layout_engine => :erb,
               :tables => true,
```


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39494/#review103313
-----------------------------------------------------------


On Oct. 20, 2015, 9:58 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39494/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2015, 9:58 p.m.)
> 
> 
> Review request for mesos, haosdent huang, Joris Van Remoortere, and Neil Conway.
> 
> 
> Bugs: MESOS-3749
>     https://issues.apache.org/jira/browse/MESOS-3749
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added libevent and ssl flags to config docs.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md c7d5da68a5cede7a8d57ccf94cebf8a10af2d9c6 
> 
> Diff: https://reviews.apache.org/r/39494/diff/
> 
> 
> Testing
> -------
> 
> Viewed in the Mesos Website Container: https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39494: Added libevent and ssl flags to config docs.

Posted by Greg Mann <gr...@mesosphere.io>.

> On Oct. 20, 2015, 9:55 p.m., Joseph Wu wrote:
> > Not really related, but do you know if markdown-style tables are supported here?

Hmmm... not sure.


> On Oct. 20, 2015, 9:55 p.m., Joseph Wu wrote:
> > docs/configuration.md, line 1768
> > <https://reviews.apache.org/r/39494/diff/1/?file=1102097#file1102097line1768>
> >
> >     You should also add a corresponding `--with-ssl` and `--with-libevent` flag.

Thanks Joseph! Added.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39494/#review103313
-----------------------------------------------------------


On Oct. 20, 2015, 9:58 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39494/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2015, 9:58 p.m.)
> 
> 
> Review request for mesos, haosdent huang, Joris Van Remoortere, and Neil Conway.
> 
> 
> Bugs: MESOS-3749
>     https://issues.apache.org/jira/browse/MESOS-3749
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added libevent and ssl flags to config docs.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md c7d5da68a5cede7a8d57ccf94cebf8a10af2d9c6 
> 
> Diff: https://reviews.apache.org/r/39494/diff/
> 
> 
> Testing
> -------
> 
> Viewed in the Mesos Website Container: https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39494: Added libevent and ssl flags to config docs.

Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39494/#review103313
-----------------------------------------------------------

Ship it!


Not really related, but do you know if markdown-style tables are supported here?


docs/configuration.md (line 1768)
<https://reviews.apache.org/r/39494/#comment161293>

    You should also add a corresponding `--with-ssl` and `--with-libevent` flag.


- Joseph Wu


On Oct. 20, 2015, 1:50 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39494/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2015, 1:50 p.m.)
> 
> 
> Review request for mesos, haosdent huang, Joris Van Remoortere, and Neil Conway.
> 
> 
> Bugs: MESOS-3749
>     https://issues.apache.org/jira/browse/MESOS-3749
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added libevent and ssl flags to config docs.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md c7d5da68a5cede7a8d57ccf94cebf8a10af2d9c6 
> 
> Diff: https://reviews.apache.org/r/39494/diff/
> 
> 
> Testing
> -------
> 
> Viewed in the Mesos Website Container: https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>