You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@knox.apache.org by lm...@apache.org on 2017/10/26 14:22:38 UTC
[02/37] knox git commit: KNOX-1054 - Make DefaultURLManager
thread-safe (Phil Zampino via Sandeep More)
KNOX-1054 - Make DefaultURLManager thread-safe (Phil Zampino via Sandeep More)
Project: http://git-wip-us.apache.org/repos/asf/knox/repo
Commit: http://git-wip-us.apache.org/repos/asf/knox/commit/d3f507f9
Tree: http://git-wip-us.apache.org/repos/asf/knox/tree/d3f507f9
Diff: http://git-wip-us.apache.org/repos/asf/knox/diff/d3f507f9
Branch: refs/heads/KNOX-1049
Commit: d3f507f9424b7deb355696c1c6d5f5aad142157d
Parents: 2666894
Author: Sandeep More <mo...@apache.org>
Authored: Wed Sep 20 21:47:35 2017 -0400
Committer: Sandeep More <mo...@apache.org>
Committed: Wed Sep 20 21:47:35 2017 -0400
----------------------------------------------------------------------
.../hadoop/gateway/ha/provider/impl/DefaultURLManager.java | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/knox/blob/d3f507f9/gateway-provider-ha/src/main/java/org/apache/hadoop/gateway/ha/provider/impl/DefaultURLManager.java
----------------------------------------------------------------------
diff --git a/gateway-provider-ha/src/main/java/org/apache/hadoop/gateway/ha/provider/impl/DefaultURLManager.java b/gateway-provider-ha/src/main/java/org/apache/hadoop/gateway/ha/provider/impl/DefaultURLManager.java
index 484a580..e76be7d 100644
--- a/gateway-provider-ha/src/main/java/org/apache/hadoop/gateway/ha/provider/impl/DefaultURLManager.java
+++ b/gateway-provider-ha/src/main/java/org/apache/hadoop/gateway/ha/provider/impl/DefaultURLManager.java
@@ -24,7 +24,6 @@ import org.apache.hadoop.gateway.ha.provider.impl.i18n.HaMessages;
import org.apache.hadoop.gateway.i18n.messages.MessagesFactory;
import java.net.URI;
-import java.util.Iterator;
import java.util.List;
import java.util.concurrent.ConcurrentLinkedQueue;
@@ -34,8 +33,6 @@ public class DefaultURLManager implements URLManager {
private ConcurrentLinkedQueue<String> urls = new ConcurrentLinkedQueue<>();
- public DefaultURLManager() {
- }
@Override
public boolean supportsConfig(HaServiceConfig config) {
@@ -48,7 +45,7 @@ public class DefaultURLManager implements URLManager {
}
@Override
- public String getActiveURL() {
+ public synchronized String getActiveURL() {
return urls.peek();
}
@@ -68,13 +65,13 @@ public class DefaultURLManager implements URLManager {
}
@Override
- public List<String> getURLs() {
+ public synchronized List<String> getURLs() {
return Lists.newArrayList(urls.iterator());
}
@Override
public synchronized void setURLs(List<String> urls) {
- if ( urls != null && !urls.isEmpty()) {
+ if (urls != null && !urls.isEmpty()) {
this.urls.clear();
this.urls.addAll(urls);
}