You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/09/06 11:10:18 UTC

[GitHub] [iotdb] cigarl opened a new pull request #3915: [cluster-refactor]split DataGroupServiceImpls into engine and impls

cigarl opened a new pull request #3915:
URL: https://github.com/apache/iotdb/pull/3915


   Split DataGroupServiceImpls into DataGroupEngine and DataGroupServiceImpls.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] cigarl commented on pull request #3915: [cluster-refactor]split DataGroupServiceImpls into engine and impls

Posted by GitBox <gi...@apache.org>.
cigarl commented on pull request #3915:
URL: https://github.com/apache/iotdb/pull/3915#issuecomment-922162650


   apply spotless to trigger _Checks_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] cigarl commented on pull request #3915: [cluster-refactor]split DataGroupServiceImpls into engine and impls

Posted by GitBox <gi...@apache.org>.
cigarl commented on pull request #3915:
URL: https://github.com/apache/iotdb/pull/3915#issuecomment-913955805


   @jixuan1989 
   If we want to split `DataGroupServiceImpls` like `StorageEngine` . Requests from clients _(in the entrance of RPC)_ should be encapsulated, and send wrappers to engine, engine try to route to their processors _(Impls)_.This change may extend the scope of modification.
   
   So,I'm just splitting out the parts that belong to Engine from `DataGroupServiceImpls`. The entrance of RPC is still in _Impls_.
   
   Please review the code if you have any time,thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] cigarl closed pull request #3915: [cluster-refactor]split DataGroupServiceImpls into engine and impls

Posted by GitBox <gi...@apache.org>.
cigarl closed pull request #3915:
URL: https://github.com/apache/iotdb/pull/3915


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org