You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by halton <gi...@git.apache.org> on 2017/06/30 01:08:06 UTC
[GitHub] cordova-mobile-spec pull request #145: CB-10718: Update instruction
GitHub user halton opened a pull request:
https://github.com/apache/cordova-mobile-spec/pull/145
CB-10718: Update instruction
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### What does this PR do?
### What testing has been done on this change?
### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/halton/cordova-mobile-spec CB-10718
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-mobile-spec/pull/145.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #145
----
commit b66d01e3ce3b50a14846155c5b816dfb164b6c6e
Author: Halton Huo <ha...@intel.com>
Date: 2017-06-27T07:13:50Z
CB-10718: Update instruction
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-mobile-spec pull request #145: CB-10718: Update instruction
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/145#discussion_r126538962
--- Diff: createmobilespec/createmobilespec.js ---
@@ -345,16 +345,13 @@ if (argv.global) {
console.log("To clone repositories:");
console.log([" ." + path.sep + "cordova-coho" + path.sep + "coho repo-clone"].concat(repos).join(" -r "));
- if (!argv.globalplugins) {
--- End diff --
what happened to this conditional
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-mobile-spec pull request #145: CB-10718: Update instruction
Posted by halton <gi...@git.apache.org>.
Github user halton commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/145#discussion_r126541593
--- Diff: createmobilespec/createmobilespec.js ---
@@ -345,16 +345,13 @@ if (argv.global) {
console.log("To clone repositories:");
console.log([" ." + path.sep + "cordova-coho" + path.sep + "coho repo-clone"].concat(repos).join(" -r "));
- if (!argv.globalplugins) {
--- End diff --
I think it is needed for all condition, anything I missed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org