[GitHub] [arrow-rs] carols10cents commented on a change in pull request #1001: Address benchmarks that aren't compiling

[GitBox <gi...@apache.org>]

carols10cents commented on a change in pull request #1001:
URL: https://github.com/apache/arrow-rs/pull/1001#discussion_r766084125



##########
File path: .github/workflows/rust.yml
##########
@@ -241,6 +241,46 @@ jobs:
           export CARGO_TARGET_DIR="/github/home/target"
           cargo clippy --features test_common --all-targets --workspace -- -D warnings -A clippy::redundant_field_names
 
+  build_benches:
+    name: Build Benchmarks (but don't run them)
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        arch: [amd64]
+        rust: [stable]
+    container:
+      image: ${{ matrix.arch }}/rust
+      env:
+        # Disable full debug symbol generation to speed up CI build and keep memory down
+        # "1" means line tables only, which is useful for panic tracebacks.
+        RUSTFLAGS: "-C debuginfo=1"
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          submodules: true
+      - name: Cache Cargo
+        uses: actions/cache@v2
+        with:
+          path: /github/home/.cargo
+          # this key equals the ones on `linux-build-lib` for re-use
+          key: cargo-cache2-
+      - name: Cache Rust dependencies
+        uses: actions/cache@v2
+        with:
+          path: /github/home/target
+          # this key equals the ones on `linux-build-lib` for re-use
+          key: ${{ runner.os }}-${{ matrix.arch }}-target-cache-${{ matrix.rust }}
+      - name: Setup Rust toolchain
+        run: |
+          rustup toolchain install ${{ matrix.rust }}
+          rustup default ${{ matrix.rust }}
+          rustup component add rustfmt clippy
+      - name: Build benchmarks
+        run: |
+          export CARGO_HOME="/github/home/.cargo"
+          export CARGO_TARGET_DIR="/github/home/target"
+          cargo build --benches --features test_common --workspace

Review comment:
       Ah, I can change it to `check`. I was keeping this new job consistent with the `wasm32-build` job.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org