You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "kszucs (via GitHub)" <gi...@apache.org> on 2026/05/04 07:03:43 UTC
[PR] chore(deps): bump opendal to 0.56, migrate to reqsign-core 3.0 [iceberg-rust]
kszucs opened a new pull request, #2401:
URL: https://github.com/apache/iceberg-rust/pull/2401
## Summary
- Bump `opendal` from `0.55` to `0.56` (now on crates.io)
- Migrate S3 credential plumbing from `reqsign 0.16` to `reqsign-aws-v4` / `reqsign-core` 3.0, required by the opendal 0.56 API
- Replace `opendal::Scheme` with `&'static str` as the cache key in `OpenDalResolvingStorage` — `opendal::Scheme` was fully removed in 0.56
- Update `CustomAwsCredentialLoader` to wrap `ProvideCredential` instead of `AwsCredentialLoad`
## Test plan
- [ ] Unit tests pass: `cargo test -p iceberg-storage-opendal`
- [ ] S3 integration tests pass against MinIO (require `make docker-up`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] chore(deps): bump opendal to 0.56, migrate to reqsign-core 3.0 [iceberg-rust]
Posted by "kszucs (via GitHub)" <gi...@apache.org>.
kszucs commented on code in PR #2401:
URL: https://github.com/apache/iceberg-rust/pull/2401#discussion_r3180046840
##########
crates/storage/opendal/src/lib.rs:
##########
@@ -482,7 +482,11 @@ impl Storage for OpenDalStorage {
} else {
format!("{relative_path}/")
};
- Ok(op.remove_all(&path).await.map_err(from_opendal_error)?)
+ Ok(op
Review Comment:
`remove_all` was deprecated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] chore(deps): bump opendal to 0.56, migrate to reqsign-core 3.0 [iceberg-rust]
Posted by "kszucs (via GitHub)" <gi...@apache.org>.
kszucs commented on code in PR #2401:
URL: https://github.com/apache/iceberg-rust/pull/2401#discussion_r3188608090
##########
crates/storage/opendal/tests/file_io_s3_test.rs:
##########
@@ -199,8 +204,8 @@ mod tests {
),
Err(e) => {
assert!(
- e.to_string()
- .contains("no valid credential found and anonymous access is not allowed")
+ e.to_string().contains("credential"),
Review Comment:
Changed it to `failed to load signing credential`
##########
crates/storage/opendal/Cargo.toml:
##########
@@ -54,6 +54,7 @@ futures = { workspace = true }
[dev-dependencies]
async-trait = { workspace = true }
iceberg_test_utils = { path = "../../test_utils", features = ["tests"] }
-reqsign = { version = "0.16.3", default-features = false }
+reqsign-aws-v4 = { version = "3.0.0" }
Review Comment:
Done, removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] chore(deps): bump opendal to 0.56, migrate to reqsign-core 3.0 [iceberg-rust]
Posted by "mbutrovich (via GitHub)" <gi...@apache.org>.
mbutrovich commented on code in PR #2401:
URL: https://github.com/apache/iceberg-rust/pull/2401#discussion_r3195476431
##########
crates/storage/opendal/src/resolving.rs:
##########
Review Comment:
I think this doc is now out of date (specifically referencing Scheme).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] chore(deps): bump opendal to 0.56, migrate to reqsign-core 3.0 [iceberg-rust]
Posted by "kszucs (via GitHub)" <gi...@apache.org>.
kszucs commented on PR #2401:
URL: https://github.com/apache/iceberg-rust/pull/2401#issuecomment-4379516034
@CTTY ready for another review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] chore(deps): bump opendal to 0.56, migrate to reqsign-core 3.0 [iceberg-rust]
Posted by "CTTY (via GitHub)" <gi...@apache.org>.
CTTY commented on code in PR #2401:
URL: https://github.com/apache/iceberg-rust/pull/2401#discussion_r3185197583
##########
crates/storage/opendal/tests/file_io_s3_test.rs:
##########
@@ -199,8 +204,8 @@ mod tests {
),
Err(e) => {
assert!(
- e.to_string()
- .contains("no valid credential found and anonymous access is not allowed")
+ e.to_string().contains("credential"),
Review Comment:
I assume the error message changed?
If so, can we loosen the string check a bit less?
##########
crates/storage/opendal/Cargo.toml:
##########
@@ -54,6 +54,7 @@ futures = { workspace = true }
[dev-dependencies]
async-trait = { workspace = true }
iceberg_test_utils = { path = "../../test_utils", features = ["tests"] }
-reqsign = { version = "0.16.3", default-features = false }
+reqsign-aws-v4 = { version = "3.0.0" }
Review Comment:
Do we really need this? it's already defined in the `dependencies` section, and tests that need this dependency should be gated by `opendal-s3` feature flag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] chore(deps): bump opendal to 0.56, migrate to reqsign-core 3.0 [iceberg-rust]
Posted by "kszucs (via GitHub)" <gi...@apache.org>.
kszucs commented on code in PR #2401:
URL: https://github.com/apache/iceberg-rust/pull/2401#discussion_r3201137443
##########
crates/storage/opendal/src/resolving.rs:
##########
Review Comment:
Updating
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] chore(deps): bump opendal to 0.56, migrate to reqsign-core 3.0 [iceberg-rust]
Posted by "kszucs (via GitHub)" <gi...@apache.org>.
kszucs commented on code in PR #2401:
URL: https://github.com/apache/iceberg-rust/pull/2401#discussion_r3201268992
##########
crates/storage/opendal/src/resolving.rs:
##########
Review Comment:
Removed the reference
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] chore(deps): bump opendal to 0.56, migrate to reqsign-core 3.0 [iceberg-rust]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #2401:
URL: https://github.com/apache/iceberg-rust/pull/2401
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] chore(deps): bump opendal to 0.56, migrate to reqsign-core 3.0 [iceberg-rust]
Posted by "CTTY (via GitHub)" <gi...@apache.org>.
CTTY commented on code in PR #2401:
URL: https://github.com/apache/iceberg-rust/pull/2401#discussion_r3196568288
##########
crates/storage/opendal/src/resolving.rs:
##########
Review Comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org