[GitHub] [flink] tillrohrmann opened a new pull request #8783: [FLINK-12863][FLINK-12865] Remove concurrency from HeartbeatManager(Sender)Impl

[GitBox <gi...@apache.org>]

tillrohrmann opened a new pull request #8783: [FLINK-12863][FLINK-12865] Remove concurrency from HeartbeatManager(Sender)Impl
URL: https://github.com/apache/flink/pull/8783
 
 
   ## What is the purpose of the change
   
   This commit makes the HeartbeatManager implementations to use the RpcEndpoint's
   main thread executor in order to remove concurrency. Furthermore, this commit changes the HeartbeatListener interface to directly return a payload instead of returning a future when
   HeartbeatListener#retrievePayload is called.
   
   Since the HeartbeatManager implementations now use the RpcEndpoint's main thread,
   we remove the splicing into the RpcEndpoint's main thread in the implementations
   of the HeartbeatListeners in the TaskExecutor, JobMaster and ResourceManager
   components.
   
   cc @azagrebin
   
   ## Brief change log
   
   * Remove future executor from HeartbeatManager implementations
   * Use the components main thread executor as the `ScheduledExecutor` for the `HeartbeatManagerImpl` in the `JobMaster`, `TaskExecutor` and `ResourceManager` component.
   * Change return type of `HeartbeatListener#retrievePayload` to synchronously return the payload. This avoids another source of concurrency.
   
   ## Verifying this change
   
   Exclude the last two commits and run `JobMasterTest#testAllocatedSlotReportDoesNotContainStaleInformation` as well as `TaskExecutorTest#testSlotReportDoesNotContainStaleInformation` in a loop. They should eventually fail.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services