You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Prasad Mujumdar <pr...@cloudera.com> on 2014/05/10 23:49:05 UTC

Re: Review Request 21301: SENTRY-193: Add schematool for creating Sentry store schema from the SQL scripts

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21301/
-----------------------------------------------------------

(Updated May 10, 2014, 9:49 p.m.)


Review request for sentry, Jarek Cecho and Sravya Tirukkovalur.


Bugs: SENTRY-193
    https://issues.apache.org/jira/browse/SENTRY-193


Repository: sentry


Description
-------

Schematool for Sentry DBStore
- Added schema script for Derby
- All schema scripts are not included in the distribution
- Added dataNucleus classes for retrieving schema version
- SentryStore by default turns off dataNucleus auto create options
- SentryStore verifies the schema version on disk being consistent with version in jar
- New schema tool that executes the given Sentry schema SQL script using Beeline
   - SentrySchemaHelper that helps executing SQL against various backend DBs, is pretty much copied from Hive


Diffs (updated)
-----

  pom.xml 373c25b 
  sentry-core/sentry-core-common/src/main/java/org/apache/sentry/SentryMain.java bf028a2 
  sentry-dist/src/main/assembly/bin.xml 7c7c4a9 
  sentry-dist/src/main/assembly/src.xml a06e521 
  sentry-policy/sentry-policy-db/pom.xml 159cff2 
  sentry-provider/sentry-provider-db/pom.xml 3fd5fc9 
  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryVersion.java PRE-CREATION 
  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo 9d68dbf 
  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 7301a1a 
  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStoreSchemaInfo.java PRE-CREATION 
  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java 3b3bdc3 
  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/SentrySchemaHelper.java PRE-CREATION 
  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/SentrySchemaTool.java PRE-CREATION 
  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java 107636a 
  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 76b3ebe 
  sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.4.0.sql PRE-CREATION 
  sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.4.0.sql 83d972b 
  sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 7f3415e 
  sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryVersion.java PRE-CREATION 
  sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/tools/TestSentrySchemaTool.java PRE-CREATION 

Diff: https://reviews.apache.org/r/21301/diff/


Testing
-------

Added new test cases for the schema tool


Thanks,

Prasad Mujumdar