You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Carsten Ziegeler <cz...@apache.org> on 2012/05/16 10:02:25 UTC
Parent pom updates
Hi,
I've updated our parent pom with SLING-2480 and SLING-2481 and I would
like to release this in the near future.
If you have anything else which could be changed/added in our parent
pom, now is a good time :)
Regards
Carsten
--
Carsten Ziegeler
cziegeler@apache.org
Re: Parent pom updates
Posted by Carsten Ziegeler <cz...@apache.org>.
2012/5/16 Bertrand Delacretaz <bd...@apache.org>:
> I have bumped junit:junit to 4.10 (from 4.8.2), but didn't run a full
> build - feel free to revert if you see problems.
Ok
>
> Also, versions:display-plugin-updates reports:
>
> INFO] The following plugin updates are available:
> [INFO] org.apache.felix:maven-bundle-plugin ................. 2.0.1 -> 2.3.7
> [INFO]
> [WARNING] The following plugins do not have their version specified:
> [WARNING] maven-compiler-plugin ...................................... 2.3.2
Yepp, I just updated the parent pom to use 2.4 of the compiler
Carsten
>
> -Bertrand
--
Carsten Ziegeler
cziegeler@apache.org
Re: Parent pom updates
Posted by Felix Meschberger <fm...@adobe.com>.
Hi,
Am 16.05.2012 um 10:39 schrieb Carsten Ziegeler:
> 2012/5/16 Felix Meschberger <fm...@adobe.com>:
>> I will create an issue and do that:
>>
>> * update bundle plugin to latest release
>> * add bndlib to dependencies to use BND annotations for package export
> and add scr annotations to dependencies? :)
Yes, makes sense.
Regards
Felix
>
> Carsten
>>
>> Regards
>> Felix
>>
>>> [INFO]
>>> [WARNING] The following plugins do not have their version specified:
>>> [WARNING] maven-compiler-plugin ...................................... 2.3.2
>>>
>>> -Bertrand
>>
>
>
>
> --
> Carsten Ziegeler
> cziegeler@apache.org
Re: Parent pom updates
Posted by Carsten Ziegeler <cz...@apache.org>.
2012/5/16 Felix Meschberger <fm...@adobe.com>:
> Hi,
>
> Am 16.05.2012 um 18:25 schrieb Justin Edelson:
>
>> On Wed, May 16, 2012 at 4:39 AM, Carsten Ziegeler <cz...@apache.org>wrote:
>>
>>> 2012/5/16 Felix Meschberger <fm...@adobe.com>:
>>>> I will create an issue and do that:
>>>>
>>>> * update bundle plugin to latest release
>>>> * add bndlib to dependencies to use BND annotations for package export
>>> and add scr annotations to dependencies? :)
>>>
>>
>> dependencies or dependency management?
>>
>> Former is easier on our projects, but latter is more "correct".
>
> I thought of "dependencies". But scr annotations are already there in "dependency management". So I add bnd lib to dependency management, too.
>
> Agreed, it is not as easy but not intrusive, too.
I thought we should go for dependencies as these artifacts are used in
nearly all modules and makes it a little bit easier to use. I know
that this might be true for other deps as well, so it's questionable.
In the end I'm fine with either way :)
Regards
Carsten
>
> Regards
> Felix
>
>>
>> Justin
>>
>>>
>>> Carsten
>>>>
>>>> Regards
>>>> Felix
>>>>
>>>>> [INFO]
>>>>> [WARNING] The following plugins do not have their version specified:
>>>>> [WARNING] maven-compiler-plugin
>>> ...................................... 2.3.2
>>>>>
>>>>> -Bertrand
>>>>
>>>
>>>
>>>
>>> --
>>> Carsten Ziegeler
>>> cziegeler@apache.org
>>>
>
--
Carsten Ziegeler
cziegeler@apache.org
Re: Parent pom updates
Posted by Felix Meschberger <fm...@adobe.com>.
Hi,
Am 16.05.2012 um 18:25 schrieb Justin Edelson:
> On Wed, May 16, 2012 at 4:39 AM, Carsten Ziegeler <cz...@apache.org>wrote:
>
>> 2012/5/16 Felix Meschberger <fm...@adobe.com>:
>>> I will create an issue and do that:
>>>
>>> * update bundle plugin to latest release
>>> * add bndlib to dependencies to use BND annotations for package export
>> and add scr annotations to dependencies? :)
>>
>
> dependencies or dependency management?
>
> Former is easier on our projects, but latter is more "correct".
I thought of "dependencies". But scr annotations are already there in "dependency management". So I add bnd lib to dependency management, too.
Agreed, it is not as easy but not intrusive, too.
Regards
Felix
>
> Justin
>
>>
>> Carsten
>>>
>>> Regards
>>> Felix
>>>
>>>> [INFO]
>>>> [WARNING] The following plugins do not have their version specified:
>>>> [WARNING] maven-compiler-plugin
>> ...................................... 2.3.2
>>>>
>>>> -Bertrand
>>>
>>
>>
>>
>> --
>> Carsten Ziegeler
>> cziegeler@apache.org
>>
Re: Parent pom updates
Posted by Justin Edelson <ju...@justinedelson.com>.
On Wed, May 16, 2012 at 4:39 AM, Carsten Ziegeler <cz...@apache.org>wrote:
> 2012/5/16 Felix Meschberger <fm...@adobe.com>:
> > I will create an issue and do that:
> >
> > * update bundle plugin to latest release
> > * add bndlib to dependencies to use BND annotations for package export
> and add scr annotations to dependencies? :)
>
dependencies or dependency management?
Former is easier on our projects, but latter is more "correct".
Justin
>
> Carsten
> >
> > Regards
> > Felix
> >
> >> [INFO]
> >> [WARNING] The following plugins do not have their version specified:
> >> [WARNING] maven-compiler-plugin
> ...................................... 2.3.2
> >>
> >> -Bertrand
> >
>
>
>
> --
> Carsten Ziegeler
> cziegeler@apache.org
>
Re: Parent pom updates
Posted by Carsten Ziegeler <cz...@apache.org>.
2012/5/16 Felix Meschberger <fm...@adobe.com>:
> I will create an issue and do that:
>
> * update bundle plugin to latest release
> * add bndlib to dependencies to use BND annotations for package export
and add scr annotations to dependencies? :)
Carsten
>
> Regards
> Felix
>
>> [INFO]
>> [WARNING] The following plugins do not have their version specified:
>> [WARNING] maven-compiler-plugin ...................................... 2.3.2
>>
>> -Bertrand
>
--
Carsten Ziegeler
cziegeler@apache.org
Re: Parent pom updates
Posted by Felix Meschberger <fm...@adobe.com>.
Hi,
Am 16.05.2012 um 10:13 schrieb Bertrand Delacretaz:
> Hi,
>
> On Wed, May 16, 2012 at 10:02 AM, Carsten Ziegeler <cz...@apache.org> wrote:
>> ...If you have anything else which could be changed/added in our parent
>> pom, now is a good time :)...
>
> I have bumped junit:junit to 4.10 (from 4.8.2), but didn't run a full
> build - feel free to revert if you see problems.
>
> Also, versions:display-plugin-updates reports:
>
> INFO] The following plugin updates are available:
> [INFO] org.apache.felix:maven-bundle-plugin ................. 2.0.1 -> 2.3.7
I will create an issue and do that:
* update bundle plugin to latest release
* add bndlib to dependencies to use BND annotations for package export
Regards
Felix
> [INFO]
> [WARNING] The following plugins do not have their version specified:
> [WARNING] maven-compiler-plugin ...................................... 2.3.2
>
> -Bertrand
Re: Parent pom updates
Posted by Bertrand Delacretaz <bd...@apache.org>.
Hi,
On Wed, May 16, 2012 at 10:02 AM, Carsten Ziegeler <cz...@apache.org> wrote:
> ...If you have anything else which could be changed/added in our parent
> pom, now is a good time :)...
I have bumped junit:junit to 4.10 (from 4.8.2), but didn't run a full
build - feel free to revert if you see problems.
Also, versions:display-plugin-updates reports:
INFO] The following plugin updates are available:
[INFO] org.apache.felix:maven-bundle-plugin ................. 2.0.1 -> 2.3.7
[INFO]
[WARNING] The following plugins do not have their version specified:
[WARNING] maven-compiler-plugin ...................................... 2.3.2
-Bertrand
Re: Parent pom updates
Posted by Carsten Ziegeler <cz...@apache.org>.
Thanks for the patch and the info - I agree, it makes sense to set
this to ignore. I just applied the patch
Carsten
2012/5/18 Robert Munteanu <rm...@adobe.com>:
> Bug and patch added
>
> SLING-2484: Sling parent should map various plugin executions to ignore
> https://issues.apache.org/jira/browse/SLING-2484
>
> Robert
>
>> -----Original Message-----
>> From: Robert Munteanu
>> Sent: Thursday, May 17, 2012 3:50 PM
>> To: dev@sling.apache.org
>> Subject: RE: Parent pom updates
>>
>> > -----Original Message-----
>> > From: Carsten Ziegeler [mailto:cziegeler@apache.org]
>> > Sent: Thursday, May 17, 2012 3:36 PM
>> > To: dev@sling.apache.org
>> > Subject: Re: Parent pom updates
>> >
>> > 2012/5/17 Robert Munteanu <rm...@adobe.com>:
>> > >> -----Original Message-----
>> > >> From: Carsten Ziegeler [mailto:cziegeler@apache.org]
>> > >> Sent: Wednesday, May 16, 2012 11:02 AM
>> > >> To: dev@sling.apache.org
>> > >> Subject: Parent pom updates
>> > >>
>> > >> Hi,
>> > >>
>> > >> I've updated our parent pom with SLING-2480 and SLING-2481 and I
>> > would
>> > >> like to release this in the near future.
>> > >> If you have anything else which could be changed/added in our
>> parent
>> > >> pom, now is a good time :)
>> > >
>> > > Hi,
>> > >
>> > > I don't know if the good time is still on, but I'd like to point
>> that
>> > the org.apache.sling:sling pom.xml configures m2eclipse to 'execute'
>> > actions for many plugins:
>> > >
>> > > * maven-dependency-plugin:unpack/copy-dependencies
>> > > * maven-antrun-plugin:run
>> > > * maven-scr-plugin:scr
>> > >
>> > > This is discouraged by the M2Eclipse developers [1] and leads to a
>> > lot of unnecessary work being done on every project build ( even
>> > incremental ones ). I've only discovered that by being annoyed by
>> > Eclipse taking so long to build the projects.
>> > >
>> > > If there is still a time window and there is no explicit reason for
>> > the 'execute' mappings I suggest moving them to 'ignore' in order to
>> > reduce Eclipse build times.
>> > >
>> > Hmm, ok to be honest, I don't know what the best approach is here.
>> > What does the default eclipse maven build do (= what is it used for)
>> > and what happens if e.g. the scr annotations are not interpreted?
>>
>>
>> 1. By default M2Eclipse maps a limited number of well-known plugin
>> goals to be executed *. If an unknown plugin execution is found in the
>> resources or compile lifecycle phase then m2eclipse does not execute it
>> but flags it as an error and requires an action:
>>
>> - install a Eclipse configurator which knowns when and how to execute
>> the maven plugin
>> - manually set the execution as 'to ignore'
>> - manually set the execution as 'to execute'
>>
>> Manually setting to execute is reserved for plugins which are stable,
>> known to execute fast, do not leak any resources and bring value in an
>> IDE environment (leading to the next part)
>>
>> 2. If the scr:scr goal is executed in Eclipse AFAIK it generates the DS
>> XML descriptors and rewrites the annotated classes to have the methods
>> specified in the XML descriptors ( bind/unbind/activate/deactivate etc
>> ).
>>
>> I am not aware of any real situtation where this is needed when working
>> in an IDE. All of the time this work is performed when packaging a
>> bundle before deployment.
>>
>> Robert
>>
>> * If you're curious to see the m2eclipse mappings open a Eclipe
>> project's properties and go to Maven -> Lifecycle Mapping .
>
--
Carsten Ziegeler
cziegeler@apache.org
RE: Parent pom updates
Posted by Robert Munteanu <rm...@adobe.com>.
Bug and patch added
SLING-2484: Sling parent should map various plugin executions to ignore
https://issues.apache.org/jira/browse/SLING-2484
Robert
> -----Original Message-----
> From: Robert Munteanu
> Sent: Thursday, May 17, 2012 3:50 PM
> To: dev@sling.apache.org
> Subject: RE: Parent pom updates
>
> > -----Original Message-----
> > From: Carsten Ziegeler [mailto:cziegeler@apache.org]
> > Sent: Thursday, May 17, 2012 3:36 PM
> > To: dev@sling.apache.org
> > Subject: Re: Parent pom updates
> >
> > 2012/5/17 Robert Munteanu <rm...@adobe.com>:
> > >> -----Original Message-----
> > >> From: Carsten Ziegeler [mailto:cziegeler@apache.org]
> > >> Sent: Wednesday, May 16, 2012 11:02 AM
> > >> To: dev@sling.apache.org
> > >> Subject: Parent pom updates
> > >>
> > >> Hi,
> > >>
> > >> I've updated our parent pom with SLING-2480 and SLING-2481 and I
> > would
> > >> like to release this in the near future.
> > >> If you have anything else which could be changed/added in our
> parent
> > >> pom, now is a good time :)
> > >
> > > Hi,
> > >
> > > I don't know if the good time is still on, but I'd like to point
> that
> > the org.apache.sling:sling pom.xml configures m2eclipse to 'execute'
> > actions for many plugins:
> > >
> > > * maven-dependency-plugin:unpack/copy-dependencies
> > > * maven-antrun-plugin:run
> > > * maven-scr-plugin:scr
> > >
> > > This is discouraged by the M2Eclipse developers [1] and leads to a
> > lot of unnecessary work being done on every project build ( even
> > incremental ones ). I've only discovered that by being annoyed by
> > Eclipse taking so long to build the projects.
> > >
> > > If there is still a time window and there is no explicit reason for
> > the 'execute' mappings I suggest moving them to 'ignore' in order to
> > reduce Eclipse build times.
> > >
> > Hmm, ok to be honest, I don't know what the best approach is here.
> > What does the default eclipse maven build do (= what is it used for)
> > and what happens if e.g. the scr annotations are not interpreted?
>
>
> 1. By default M2Eclipse maps a limited number of well-known plugin
> goals to be executed *. If an unknown plugin execution is found in the
> resources or compile lifecycle phase then m2eclipse does not execute it
> but flags it as an error and requires an action:
>
> - install a Eclipse configurator which knowns when and how to execute
> the maven plugin
> - manually set the execution as 'to ignore'
> - manually set the execution as 'to execute'
>
> Manually setting to execute is reserved for plugins which are stable,
> known to execute fast, do not leak any resources and bring value in an
> IDE environment (leading to the next part)
>
> 2. If the scr:scr goal is executed in Eclipse AFAIK it generates the DS
> XML descriptors and rewrites the annotated classes to have the methods
> specified in the XML descriptors ( bind/unbind/activate/deactivate etc
> ).
>
> I am not aware of any real situtation where this is needed when working
> in an IDE. All of the time this work is performed when packaging a
> bundle before deployment.
>
> Robert
>
> * If you're curious to see the m2eclipse mappings open a Eclipe
> project's properties and go to Maven -> Lifecycle Mapping .
Re: Parent pom updates
Posted by Felix Meschberger <fm...@adobe.com>.
Hi
Am 17.05.2012 um 14:35 schrieb Carsten Ziegeler:
> 2012/5/17 Robert Munteanu <rm...@adobe.com>:
>>> -----Original Message-----
>>> From: Carsten Ziegeler [mailto:cziegeler@apache.org]
>>> Sent: Wednesday, May 16, 2012 11:02 AM
>>> To: dev@sling.apache.org
>>> Subject: Parent pom updates
>>>
>>> Hi,
>>>
>>> I've updated our parent pom with SLING-2480 and SLING-2481 and I would
>>> like to release this in the near future.
>>> If you have anything else which could be changed/added in our parent
>>> pom, now is a good time :)
>>
>> Hi,
>>
>> I don't know if the good time is still on, but I'd like to point that the org.apache.sling:sling pom.xml configures m2eclipse to 'execute' actions for many plugins:
>>
>> * maven-dependency-plugin:unpack/copy-dependencies
>> * maven-antrun-plugin:run
>> * maven-scr-plugin:scr
>>
>> This is discouraged by the M2Eclipse developers [1] and leads to a lot of unnecessary work being done on every project build ( even incremental ones ). I've only discovered that by being annoyed by Eclipse taking so long to build the projects.
>>
>> If there is still a time window and there is no explicit reason for the 'execute' mappings I suggest moving them to 'ignore' in order to reduce Eclipse build times.
>>
> Hmm, ok to be honest, I don't know what the best approach is here.
> What does the default eclipse maven build do (= what is it used for)
> and what happens if e.g. the scr annotations are not interpreted?
These are required on the final bundle only, anyway. For incremental build support of the annotations we should probably plug directly into Eclipse as a plugin instead of through the maven build.
I am fine with disabling those for incremental build.
Regards
Felix
>
> Carsten
>
>> Robert
>>
>> [1]: http://wiki.eclipse.org/M2E_plugin_execution_not_covered#execute_plugin_goal
>>
>>>
>>> Regards
>>> Carsten
>>> --
>>> Carsten Ziegeler
>>> cziegeler@apache.org
>
>
>
> --
> Carsten Ziegeler
> cziegeler@apache.org
RE: Parent pom updates
Posted by Robert Munteanu <rm...@adobe.com>.
> -----Original Message-----
> From: Carsten Ziegeler [mailto:cziegeler@apache.org]
> Sent: Thursday, May 17, 2012 3:36 PM
> To: dev@sling.apache.org
> Subject: Re: Parent pom updates
>
> 2012/5/17 Robert Munteanu <rm...@adobe.com>:
> >> -----Original Message-----
> >> From: Carsten Ziegeler [mailto:cziegeler@apache.org]
> >> Sent: Wednesday, May 16, 2012 11:02 AM
> >> To: dev@sling.apache.org
> >> Subject: Parent pom updates
> >>
> >> Hi,
> >>
> >> I've updated our parent pom with SLING-2480 and SLING-2481 and I
> would
> >> like to release this in the near future.
> >> If you have anything else which could be changed/added in our parent
> >> pom, now is a good time :)
> >
> > Hi,
> >
> > I don't know if the good time is still on, but I'd like to point that
> the org.apache.sling:sling pom.xml configures m2eclipse to 'execute'
> actions for many plugins:
> >
> > * maven-dependency-plugin:unpack/copy-dependencies
> > * maven-antrun-plugin:run
> > * maven-scr-plugin:scr
> >
> > This is discouraged by the M2Eclipse developers [1] and leads to a
> lot of unnecessary work being done on every project build ( even
> incremental ones ). I've only discovered that by being annoyed by
> Eclipse taking so long to build the projects.
> >
> > If there is still a time window and there is no explicit reason for
> the 'execute' mappings I suggest moving them to 'ignore' in order to
> reduce Eclipse build times.
> >
> Hmm, ok to be honest, I don't know what the best approach is here.
> What does the default eclipse maven build do (= what is it used for)
> and what happens if e.g. the scr annotations are not interpreted?
1. By default M2Eclipse maps a limited number of well-known plugin goals to be executed *. If an unknown plugin execution is found in the resources or compile lifecycle phase then m2eclipse does not execute it but flags it as an error and requires an action:
- install a Eclipse configurator which knowns when and how to execute the maven plugin
- manually set the execution as 'to ignore'
- manually set the execution as 'to execute'
Manually setting to execute is reserved for plugins which are stable, known to execute fast, do not leak any resources and bring value in an IDE environment (leading to the next part)
2. If the scr:scr goal is executed in Eclipse AFAIK it generates the DS XML descriptors and rewrites the annotated classes to have the methods specified in the XML descriptors ( bind/unbind/activate/deactivate etc ).
I am not aware of any real situtation where this is needed when working in an IDE. All of the time this work is performed when packaging a bundle before deployment.
Robert
* If you're curious to see the m2eclipse mappings open a Eclipe project's properties and go to Maven -> Lifecycle Mapping .
Re: Parent pom updates
Posted by Carsten Ziegeler <cz...@apache.org>.
2012/5/17 Robert Munteanu <rm...@adobe.com>:
>> -----Original Message-----
>> From: Carsten Ziegeler [mailto:cziegeler@apache.org]
>> Sent: Wednesday, May 16, 2012 11:02 AM
>> To: dev@sling.apache.org
>> Subject: Parent pom updates
>>
>> Hi,
>>
>> I've updated our parent pom with SLING-2480 and SLING-2481 and I would
>> like to release this in the near future.
>> If you have anything else which could be changed/added in our parent
>> pom, now is a good time :)
>
> Hi,
>
> I don't know if the good time is still on, but I'd like to point that the org.apache.sling:sling pom.xml configures m2eclipse to 'execute' actions for many plugins:
>
> * maven-dependency-plugin:unpack/copy-dependencies
> * maven-antrun-plugin:run
> * maven-scr-plugin:scr
>
> This is discouraged by the M2Eclipse developers [1] and leads to a lot of unnecessary work being done on every project build ( even incremental ones ). I've only discovered that by being annoyed by Eclipse taking so long to build the projects.
>
> If there is still a time window and there is no explicit reason for the 'execute' mappings I suggest moving them to 'ignore' in order to reduce Eclipse build times.
>
Hmm, ok to be honest, I don't know what the best approach is here.
What does the default eclipse maven build do (= what is it used for)
and what happens if e.g. the scr annotations are not interpreted?
Carsten
> Robert
>
> [1]: http://wiki.eclipse.org/M2E_plugin_execution_not_covered#execute_plugin_goal
>
>>
>> Regards
>> Carsten
>> --
>> Carsten Ziegeler
>> cziegeler@apache.org
--
Carsten Ziegeler
cziegeler@apache.org
RE: Parent pom updates
Posted by Robert Munteanu <rm...@adobe.com>.
> -----Original Message-----
> From: Carsten Ziegeler [mailto:cziegeler@apache.org]
> Sent: Wednesday, May 16, 2012 11:02 AM
> To: dev@sling.apache.org
> Subject: Parent pom updates
>
> Hi,
>
> I've updated our parent pom with SLING-2480 and SLING-2481 and I would
> like to release this in the near future.
> If you have anything else which could be changed/added in our parent
> pom, now is a good time :)
Hi,
I don't know if the good time is still on, but I'd like to point that the org.apache.sling:sling pom.xml configures m2eclipse to 'execute' actions for many plugins:
* maven-dependency-plugin:unpack/copy-dependencies
* maven-antrun-plugin:run
* maven-scr-plugin:scr
This is discouraged by the M2Eclipse developers [1] and leads to a lot of unnecessary work being done on every project build ( even incremental ones ). I've only discovered that by being annoyed by Eclipse taking so long to build the projects.
If there is still a time window and there is no explicit reason for the 'execute' mappings I suggest moving them to 'ignore' in order to reduce Eclipse build times.
Robert
[1]: http://wiki.eclipse.org/M2E_plugin_execution_not_covered#execute_plugin_goal
>
> Regards
> Carsten
> --
> Carsten Ziegeler
> cziegeler@apache.org