You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by kk...@apache.org on 2017/09/26 08:02:34 UTC

svn commit: r1809711 - /tomcat/trunk/java/org/apache/catalina/webresources/AbstractFileResourceSet.java

Author: kkolinko
Date: Tue Sep 26 08:02:34 2017
New Revision: 1809711

URL: http://svn.apache.org/viewvc?rev=1809711&view=rev
Log:
Cache the value earlier. Followup to r1809684

Modified:
    tomcat/trunk/java/org/apache/catalina/webresources/AbstractFileResourceSet.java

Modified: tomcat/trunk/java/org/apache/catalina/webresources/AbstractFileResourceSet.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/webresources/AbstractFileResourceSet.java?rev=1809711&r1=1809710&r2=1809711&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/webresources/AbstractFileResourceSet.java (original)
+++ tomcat/trunk/java/org/apache/catalina/webresources/AbstractFileResourceSet.java Tue Sep 26 08:02:34 2017
@@ -136,12 +136,12 @@ public abstract class AbstractFileResour
 
 
     private boolean isInvalidWindowsFilename(String name) {
-        if (name.length() == 0) {
+        final int len = name.length();
+        if (len == 0) {
             return false;
         }
         // This consistently ~10 times faster than the equivalent regular
         // expression irrespective of input length.
-        final int len = name.length();
         for (int i = 0; i < len; i++) {
             char c = name.charAt(i);
             if (c == '\"' || c == '<' || c == '>') {



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org