You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Mehul Parikh <me...@freestoneinfotech.com> on 2019/10/02 09:27:20 UTC
Re: Review Request 71552: RANGER-2594: Improve policy validation
performance during delete
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71552/#review218016
-----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java
Lines 2181 (patched)
<https://reviews.apache.org/r/71552/#comment305482>
Getting compilation error :
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.3:compile (default-compile) on project security-admin-web: Compilation failure
[ERROR] /Users/mehul/Workspace/XaSecure/ranger/security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java:[2181,9] error: policyExists(Long) in ServiceDBStore cannot implement policyExists(Long) in ServiceStore
- Mehul Parikh
On Sept. 29, 2019, 1:03 a.m., Andrew Luo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71552/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2019, 1:03 a.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-2594
> https://issues.apache.org/jira/browse/RANGER-2594
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Deletion of large policies (those with several thousand users or resources) is slow - one reason for this is that we fetch the entire policy during validation, when we only need to check if the policy exists or not.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java a85410782
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidator.java f31483e97
> agents-common/src/main/java/org/apache/ranger/plugin/store/ServiceStore.java ba7407fc4
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 85db57719
>
>
> Diff: https://reviews.apache.org/r/71552/diff/1/
>
>
> Testing
> -------
>
> Unit tests, and tested end-to-end
>
>
> Thanks,
>
> Andrew Luo
>
>
Re: Review Request 71552: RANGER-2594: Improve policy validation
performance during delete
Posted by Andrew Luo <an...@outlook.com>.
> On Oct. 2, 2019, 9:27 a.m., Mehul Parikh wrote:
> > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java
> > Lines 2181 (patched)
> > <https://reviews.apache.org/r/71552/diff/1/?file=2167328#file2167328line2181>
> >
> > Getting compilation error :
> >
> > [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.3:compile (default-compile) on project security-admin-web: Compilation failure
> > [ERROR] /Users/mehul/Workspace/XaSecure/ranger/security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java:[2181,9] error: policyExists(Long) in ServiceDBStore cannot implement policyExists(Long) in ServiceStore
Thanks for reviewing. I fixed the issue, sorry, I made a mistake when forward-porting this fix from the version that I'm using.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71552/#review218016
-----------------------------------------------------------
On Oct. 3, 2019, 7:45 a.m., Andrew Luo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71552/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2019, 7:45 a.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-2594
> https://issues.apache.org/jira/browse/RANGER-2594
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Deletion of large policies (those with several thousand users or resources) is slow - one reason for this is that we fetch the entire policy during validation, when we only need to check if the policy exists or not.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java a85410782
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidator.java f31483e97
> agents-common/src/main/java/org/apache/ranger/plugin/store/ServiceStore.java ba7407fc4
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 85db57719
>
>
> Diff: https://reviews.apache.org/r/71552/diff/2/
>
>
> Testing
> -------
>
> Unit tests, and tested end-to-end
>
>
> Thanks,
>
> Andrew Luo
>
>