You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/08/19 20:26:44 UTC
Review Request 37617: Added an error message to
MesosContainerizerLaunch command.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37617/
-----------------------------------------------------------
Review request for mesos, Marco Massenzio and Vinod Kone.
Bugs: MESOS-3296
https://issues.apache.org/jira/browse/MESOS-3296
Repository: mesos
Description
-------
Added an error message to MesosContainerizerLaunch command.
So that we can triage MESOS-3296.
Diffs
-----
src/slave/containerizer/mesos/launch.cpp bd594d3f3d729aa000a1a7fbf9038f6cfcbb169b
Diff: https://reviews.apache.org/r/37617/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 37617: Added an error message to
MesosContainerizerLaunch command.
Posted by Marco Massenzio <ma...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37617/#review95891
-----------------------------------------------------------
Ship it!
Ship It!
- Marco Massenzio
On Aug. 19, 2015, 6:26 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37617/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2015, 6:26 p.m.)
>
>
> Review request for mesos, Marco Massenzio and Vinod Kone.
>
>
> Bugs: MESOS-3296
> https://issues.apache.org/jira/browse/MESOS-3296
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added an error message to MesosContainerizerLaunch command.
>
> So that we can triage MESOS-3296.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/launch.cpp bd594d3f3d729aa000a1a7fbf9038f6cfcbb169b
>
> Diff: https://reviews.apache.org/r/37617/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 37617: Added an error message to
MesosContainerizerLaunch command.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37617/#review95960
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Aug. 19, 2015, 6:26 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37617/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2015, 6:26 p.m.)
>
>
> Review request for mesos, Marco Massenzio and Vinod Kone.
>
>
> Bugs: MESOS-3296
> https://issues.apache.org/jira/browse/MESOS-3296
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added an error message to MesosContainerizerLaunch command.
>
> So that we can triage MESOS-3296.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/launch.cpp bd594d3f3d729aa000a1a7fbf9038f6cfcbb169b
>
> Diff: https://reviews.apache.org/r/37617/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 37617: Added an error message to
MesosContainerizerLaunch command.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37617/#review95930
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37617]
All tests passed.
- Mesos ReviewBot
On Aug. 19, 2015, 6:26 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37617/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2015, 6:26 p.m.)
>
>
> Review request for mesos, Marco Massenzio and Vinod Kone.
>
>
> Bugs: MESOS-3296
> https://issues.apache.org/jira/browse/MESOS-3296
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added an error message to MesosContainerizerLaunch command.
>
> So that we can triage MESOS-3296.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/launch.cpp bd594d3f3d729aa000a1a7fbf9038f6cfcbb169b
>
> Diff: https://reviews.apache.org/r/37617/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>