You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/19 11:51:05 UTC
[GitHub] [airflow] mikemoto opened a new pull request #19706: add DagrunRunningDep into RUNNING_DEPS
mikemoto opened a new pull request #19706:
URL: https://github.com/apache/airflow/pull/19706
Let see this case:
1. i use sequential executor, and use sqlite as db
2. the dag has two task(as the pic shown below), and there is NO dependeny between them
Then, whent i start a dag run, both task will be added to sequential executor in the same schduler loop.
When i stop the dagrun when the first taskinstance(let's assume the is the [sleep_1] step) is running, using set_dag_run_state_to_failed function from airflow.api.common.experimental.mark_tasks. I can see the state of dagrun will be changed into FAILED, and the state of taskinstance of task [sleep_1] will also changed into FAILED, but the taskinstance of [sleep_2] will be left unchanged(queued)
Then, something weired happend, the task instance of [sleep_2] will be executed as usual. That's not what i want!
I check the code, and find the sequential executor will still run all the taskintance in commane_to_run list, even if some taskinstance of the same dagrun has already failed.
And, even when running [airflow task run] command, the check_and_change_state_before_execution function in model/taskinstance.py will not check whether the dagrun of the taskinstance has failed or not.
So i add the add DagrunRunningDep into RUNNING_DEPS, and things go right again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mikemoto closed pull request #19706: fix bug: add DagrunRunningDep into RUNNING_DEPS
Posted by GitBox <gi...@apache.org>.
mikemoto closed pull request #19706:
URL: https://github.com/apache/airflow/pull/19706
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #19706: add DagrunRunningDep into RUNNING_DEPS
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #19706:
URL: https://github.com/apache/airflow/pull/19706#issuecomment-974005374
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org