You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/12/02 06:35:58 UTC
[GitHub] [druid] clintropolis opened a new pull request #12016: allow `DruidSchema` to fallback to segment metadata 'type' if 'typeSignature' is null
clintropolis opened a new pull request #12016:
URL: https://github.com/apache/druid/pull/12016
### Description
This PR adds a fallback mechanism to `DruidSchema` to use the legacy 'type' string field of segment metadata results, after #11895 changed `DruidSchema` to use a new, richer, `typeSignature` field instead. This fixes an issue where the SQL schema for a datasource can be marked entirely as `COMPLEX` typed columns if a broker is updated to 0.23 before historical servers are, and will remain in this state until restarted or all segments have been moved to new servers after all historicals are upgraded. See https://github.com/apache/druid/pull/11713#issuecomment-983269047 for details.
This PR has:
- [x] been self-reviewed.
- [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [x] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis merged pull request #12016: allow `DruidSchema` to fallback to segment metadata 'type' if 'typeSignature' is null
Posted by GitBox <gi...@apache.org>.
clintropolis merged pull request #12016:
URL: https://github.com/apache/druid/pull/12016
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org