You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2019/04/14 21:33:33 UTC

[GitHub] [drill] vdiravka commented on a change in pull request #1746: DRILL-7169: Rename drill-root ArtifactID to apache-drill

vdiravka commented on a change in pull request #1746: DRILL-7169: Rename drill-root ArtifactID to apache-drill
URL: https://github.com/apache/drill/pull/1746#discussion_r275171927
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -42,7 +42,7 @@
     <maven.compiler.target>1.8</maven.compiler.target>
     <sourceReleaseAssemblyDescriptor>source-release-zip-tar</sourceReleaseAssemblyDescriptor>
 
-    <target.gen.source.path>${project.basedir}/target/generated-sources</target.gen.source.path>
+    <target.gen.source.path>${project.build.directory}/generated-sources</target.gen.source.path>
     <proto.cas.path>${project.basedir}/src/main/protobuf/</proto.cas.path>
 
 Review comment:
   1. Looks like it was introduced for a long time ago for `maven-antrun-plugin`.
   https://github.com/apache/drill/commit/b53933f225e21b890a9cc25545be7ce4223ba0ce#diff-0c2b5a9caaab6aa53c1c6c7dead7be77R118
   But a little bit later this usage was removed. I think it is safe to remove it.
   
   2. Modified

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services