You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "pbacsko (via GitHub)" <gi...@apache.org> on 2023/06/13 09:26:16 UTC
[GitHub] [yunikorn-core] pbacsko opened a new pull request, #565: [YUNIKORN-1811] Flaky tests TestPlaceholderSmallerThanReal and TestPlaceholderSmallerMulti
pbacsko opened a new pull request, #565:
URL: https://github.com/apache/yunikorn-core/pull/565
### What is this PR for?
Two unit tests can fail due to the very low value of the timeout (10 msec).
### What type of PR is it?
* [x] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1811
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] zhuqi-lucas closed pull request #565: [YUNIKORN-1811] Flaky tests TestPlaceholderSmallerThanReal and TestPlaceholderSmallerMulti
Posted by "zhuqi-lucas (via GitHub)" <gi...@apache.org>.
zhuqi-lucas closed pull request #565: [YUNIKORN-1811] Flaky tests TestPlaceholderSmallerThanReal and TestPlaceholderSmallerMulti
URL: https://github.com/apache/yunikorn-core/pull/565
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #565: [YUNIKORN-1811] Flaky tests TestPlaceholderSmallerThanReal and TestPlaceholderSmallerMulti
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #565:
URL: https://github.com/apache/yunikorn-core/pull/565#issuecomment-1588909248
## [Codecov](https://app.codecov.io/gh/apache/yunikorn-core/pull/565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#565](https://app.codecov.io/gh/apache/yunikorn-core/pull/565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1421ddc) into [master](https://app.codecov.io/gh/apache/yunikorn-core/commit/01162d2d7b2c8b2462ceee5f5781a1a426a0ada3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (01162d2) will **decrease** coverage by `0.04%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #565 +/- ##
==========================================
- Coverage 75.03% 75.00% -0.04%
==========================================
Files 72 72
Lines 11558 11542 -16
==========================================
- Hits 8673 8657 -16
Misses 2581 2581
Partials 304 304
```
| [Impacted Files](https://app.codecov.io/gh/apache/yunikorn-core/pull/565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [pkg/events/events.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2V2ZW50cy9ldmVudHMuZ28=) | `100.00% <100.00%> (ø)` | |
| [pkg/scheduler/objects/events.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2V2ZW50cy5nbw==) | `100.00% <100.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org