You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "JackieTien97 (via GitHub)" <gi...@apache.org> on 2026/09/28 03:25:26 UTC
[PR] [Query] Allow concurrent local fragment execution for last-query collection [iotdb]
JackieTien97 opened a new pull request, #18727:
URL: https://github.com/apache/iotdb/pull/18727
## Description
`LastQueryCollectOperator` only checks the current child's blocking state. Local upstream fragment instances wait for their downstream source handles to request data, so later fragments remain blocked until earlier children have been consumed.
Call `isBlocked()` on every child once during initialization, matching `CollectOperator`, so fragment instances on the same DataNode can execute concurrently. Subsequent calls continue to wait on the current child, preserving the existing result consumption order.
## Validation
- `mvn spotless:apply -pl iotdb-core/datanode`
- `mvn clean test -pl iotdb-core/datanode -am -Dtest=LastQueryCollectOperatorTest,LocalSourceHandleTest,LocalSinkChannelTest -Dsurefire.failIfNoSpecifiedTests=false`
All 6 tests passed. The new regression tests use local exchange queues to verify that both producers are unblocked, a later fragment can produce data before the current fragment finishes, and results are still consumed in child order. They also cover empty input and completion.
<hr>
This PR has:
- [x] been self-reviewed.
- [x] added comments explaining the intent of the initialization.
- [x] added unit tests covering the new behavior.
<hr>
##### Key changed/added classes
- `LastQueryCollectOperator`
- `LastQueryCollectOperatorTest`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Query] Allow concurrent local fragment execution for last-query collection [iotdb]
Posted by "JackieTien97 (via GitHub)" <gi...@apache.org>.
JackieTien97 merged PR #18727:
URL: https://github.com/apache/iotdb/pull/18727
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org