You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "pingpingy1 (via GitHub)" <gi...@apache.org> on 2024/03/15 04:57:59 UTC

[PR] Guard DefaultExpressionEngineSymbols against empty builder [commons-configuration]

pingpingy1 opened a new pull request, #382:
URL: https://github.com/apache/commons-configuration/pull/382

   If the symbols provided to the `DefaultExpressionEngineSymbols` is `null`, then they are saved to the respective `private final` properties, which is bound to throw an NPE at a later time. One prominent case of this is when the builder is not modified before creating an instance. This commit implements a `null`-guard to use the default values when `null` is provided.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Guard DefaultExpressionEngineSymbols against empty builder [commons-configuration]

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #382:
URL: https://github.com/apache/commons-configuration/pull/382#issuecomment-2002471829

   @pingpingy1 Please address my comments.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Guard DefaultExpressionEngineSymbols against empty builder [commons-configuration]

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #382:
URL: https://github.com/apache/commons-configuration/pull/382#issuecomment-1999551723

   @pingpingy1 
   This PR breaks the build:
   ```
   Error:  Failures: 
   Error:    TestDefaultConfigurationKey.testAppendDelimitersWithoutEscaping:134 expected: <key.test.more.tests> but was: <key........test.more...tests>
   Error:    TestDefaultConfigurationKey.testConstructAttributeKeyWithoutEndMarkers:248 expected: <.test> but was: <.test]>
   Error:    TestDefaultConfigurationKey.testIsAttributeKeyWithoutEndMarkers:319 expected: <true> but was: <false>
   Error:    TestDefaultConfigurationKey.testIterateAttributeEqualsPropertyDelimiter:383 expected: <true> but was: <false>
   Error:    TestDefaultConfigurationKey.testIterateWithoutEscapeDelimiter:455 expected: <my..elem.trailing..dot...strange> but was: <..my..elem.trailing..dot...strange>
   Error:    TestDefaultExpressionEngine.testAttributeKeyWithAlternativeSyntax:284 expected: <@test> but was: <@test]>
   Error:    TestDefaultExpressionEngine.testNodeKeyWithAlternativeSyntaxAttributePropertyDelimiter:378 expected: </test> but was: </test]>
   Error:    TestDefaultExpressionEngine.testPrepareAddWithAlternativeSyntax:490 expected: <attr> but was: <@attr>
   Error:    TestDefaultExpressionEngine.testQueryAlternativeSyntax:561->checkAttributeValue:137->checkKey:153->query:222 expected: <1> but was: <0>
   Error:    TestDefaultExpressionEngine.testQueryAttributeEmulation:575->checkAttributeValue:137->checkKey:153->query:222 expected: <1> but was: <0>
   [INFO] 
   Error:  Tests run: 2881, Failures: 10, Errors: 0, Skipped: 2
   ```
   Please fix or close.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Guard DefaultExpressionEngineSymbols against empty builder [commons-configuration]

Posted by "pingpingy1 (via GitHub)" <gi...@apache.org>.
pingpingy1 commented on PR #382:
URL: https://github.com/apache/commons-configuration/pull/382#issuecomment-2002914638

   @garydgregory Yeah, I totally misunderstood how `null` delimiters were used in other parts of the program. Let me close this PR.
   Sorry for the trouble.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Guard DefaultExpressionEngineSymbols against empty builder [commons-configuration]

Posted by "pingpingy1 (via GitHub)" <gi...@apache.org>.
pingpingy1 closed pull request #382: Guard DefaultExpressionEngineSymbols against empty builder
URL: https://github.com/apache/commons-configuration/pull/382


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org