You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/04/12 23:12:33 UTC
[GitHub] [incubator-druid] jon-wei commented on a change in pull request
#7464: Adjust BufferAggregator.get() impls to return copies
jon-wei commented on a change in pull request #7464: Adjust BufferAggregator.get() impls to return copies
URL: https://github.com/apache/incubator-druid/pull/7464#discussion_r275088332
##########
File path: processing/src/main/java/org/apache/druid/query/aggregation/BufferAggregator.java
##########
@@ -72,7 +72,9 @@
*
* Converts the given byte buffer representation into an intermediate aggregate Object
*
- * <b>Implementations must not change the position, limit or mark of the given buffer</b>
+ * <b>Implementations must not change the position, limit or mark of the given buffer.</b>
+ *
+ * <b>The object returned must not have any references to the given buffer (i.e., make a copy).</b>
Review comment:
Added the rationale here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org