You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2022/03/04 17:00:59 UTC
[kudu-CR](branch-1.16.x) [thirdparty] build curl without brotli
Attila Bukor has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18292
Change subject: [thirdparty] build curl without brotli
......................................................................
[thirdparty] build curl without brotli
The default build configuration for curl has the brotli compression
opportunistically enabled. If brotli libraries and headers are found
at the build machine, the configure script picks them up and then the
generated curl library depends on corresponding brotli libraries. That
on itself requires extra brotli libraries to be linked in when building
statically linked kudu binaries (that's so for RELEASE builds).
This patch disables broli for the libcurl library build as a part of
Kudu's thirdparty.
Change-Id: I14ef696302cc1653f3efd6dba5714ce3927c1d20
Reviewed-on: http://gerrit.cloudera.org:8080/18288
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
(cherry picked from commit 1750aedbbe20134b7dec52cd52ac6c2e330d77e0)
---
M thirdparty/build-definitions.sh
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/18292/1
--
To view, visit http://gerrit.cloudera.org:8080/18292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I14ef696302cc1653f3efd6dba5714ce3927c1d20
Gerrit-Change-Number: 18292
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
[kudu-CR](branch-1.16.x) [thirdparty] build curl without brotli
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18292 )
Change subject: [thirdparty] build curl without brotli
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I14ef696302cc1653f3efd6dba5714ce3927c1d20
Gerrit-Change-Number: 18292
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 04 Mar 2022 18:14:09 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.16.x) [thirdparty] build curl without brotli
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18292 )
Change subject: [thirdparty] build curl without brotli
......................................................................
[thirdparty] build curl without brotli
The default build configuration for curl has the brotli compression
opportunistically enabled. If brotli libraries and headers are found
at the build machine, the configure script picks them up and then the
generated curl library depends on corresponding brotli libraries. That
on itself requires extra brotli libraries to be linked in when building
statically linked kudu binaries (that's so for RELEASE builds).
This patch disables broli for the libcurl library build as a part of
Kudu's thirdparty.
Change-Id: I14ef696302cc1653f3efd6dba5714ce3927c1d20
Reviewed-on: http://gerrit.cloudera.org:8080/18288
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
(cherry picked from commit 1750aedbbe20134b7dec52cd52ac6c2e330d77e0)
Reviewed-on: http://gerrit.cloudera.org:8080/18292
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M thirdparty/build-definitions.sh
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I14ef696302cc1653f3efd6dba5714ce3927c1d20
Gerrit-Change-Number: 18292
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.16.x) [thirdparty] build curl without brotli
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18292 )
Change subject: [thirdparty] build curl without brotli
......................................................................
Patch Set 1: Verified+1
Unrelated test failure (DEBUG configuration): Could not submit C++ distributed test job
--
To view, visit http://gerrit.cloudera.org:8080/18292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I14ef696302cc1653f3efd6dba5714ce3927c1d20
Gerrit-Change-Number: 18292
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 04 Mar 2022 18:15:24 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.16.x) [thirdparty] build curl without brotli
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18292 )
Change subject: [thirdparty] build curl without brotli
......................................................................
Patch Set 1:
> Patch Set 1: Cherry Picked from branch master.
Alexey, I assume this should be backported to 1.16?
--
To view, visit http://gerrit.cloudera.org:8080/18292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I14ef696302cc1653f3efd6dba5714ce3927c1d20
Gerrit-Change-Number: 18292
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 04 Mar 2022 17:01:27 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.16.x) [thirdparty] build curl without brotli
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18292 )
Change subject: [thirdparty] build curl without brotli
......................................................................
Patch Set 1:
> > Patch Set 1: Cherry Picked from branch master.
>
> Alexey, I assume this should be backported to 1.16?
Right -- this needs to be backported to 1.16.
Thank you Attila!
--
To view, visit http://gerrit.cloudera.org:8080/18292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I14ef696302cc1653f3efd6dba5714ce3927c1d20
Gerrit-Change-Number: 18292
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 04 Mar 2022 18:14:40 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.16.x) [thirdparty] build curl without brotli
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [thirdparty] build curl without brotli
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/18292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I14ef696302cc1653f3efd6dba5714ce3927c1d20
Gerrit-Change-Number: 18292
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)