You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/12/09 14:24:37 UTC
[GitHub] [flink-connector-elasticsearch] reta opened a new pull request, #49: FLINK-30352: [Connectors/Elasticsearch] Document missing configuration properties
reta opened a new pull request, #49:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/49
There is a number of configuration properties which are not documented:
- sink.delivery-guarantee
- connection.request-timeout
- connection.timeout
- socket.timeout
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-elasticsearch] reta commented on pull request #49: [FLINK-30352] [connectors/elasticsearch] Document missing configuration properties
Posted by GitBox <gi...@apache.org>.
reta commented on PR #49:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/49#issuecomment-1344376924
@zentol please take a look, closing the gap in Elasticsearch configuration documentation, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-elasticsearch] zentol merged pull request #49: [FLINK-30352] [connectors/elasticsearch] Document missing configuration properties
Posted by GitBox <gi...@apache.org>.
zentol merged PR #49:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/49
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-elasticsearch] boring-cyborg[bot] commented on pull request #49: [FLINK-30352] [connectors/elasticsearch] Document missing configuration properties
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #49:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/49#issuecomment-1346798659
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-elasticsearch] boring-cyborg[bot] commented on pull request #49: FLINK-30352: [Connectors/Elasticsearch] Document missing configuration properties
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #49:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/49#issuecomment-1344371414
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-elasticsearch] reta commented on a diff in pull request #49: [FLINK-30352] [connectors/elasticsearch] Document missing configuration properties
Posted by GitBox <gi...@apache.org>.
reta commented on code in PR #49:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/49#discussion_r1045832024
##########
docs/content.zh/docs/connectors/table/elasticsearch.md:
##########
@@ -143,6 +143,19 @@ CREATE TABLE myUserTable (
</ul>
</td>
</tr>
+ <tr>
Review Comment:
The `timeout`s were documented, only `sink.delivery-guarantee` were missed
##########
docs/content.zh/docs/connectors/table/elasticsearch.md:
##########
@@ -143,6 +143,19 @@ CREATE TABLE myUserTable (
</ul>
</td>
</tr>
+ <tr>
Review Comment:
The `timeout`s were documented, only `sink.delivery-guarantee` was missed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-elasticsearch] reta commented on pull request #49: [FLINK-30352] [connectors/elasticsearch] Document missing configuration properties
Posted by GitBox <gi...@apache.org>.
reta commented on PR #49:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/49#issuecomment-1346427838
> Please also update the chinese version of the docs under content.zh.
@zentol what is the process here? I can only do English, someone will translate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-elasticsearch] zentol commented on pull request #49: [FLINK-30352] [connectors/elasticsearch] Document missing configuration properties
Posted by GitBox <gi...@apache.org>.
zentol commented on PR #49:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/49#issuecomment-1346453124
> @zentol what is the process here? I can only do English, someone will translate?
You can add the snippets in english, and someone may pick up the translation at some point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org