[GitHub] betodealmeida commented on issue #5177: Time shift difference

[GitBox <gi...@apache.org>]

betodealmeida commented on issue #5177: Time shift difference
URL: https://github.com/apache/incubator-superset/pull/5177#issuecomment-396713012
 
 
   > I think this is effectively the same as a superior Period Ratio isn't it? If so we should db migrate to translate the slices.
   
   I'm not familiar with the period ratio, and it doesn't seem to map 1:1 to the comparison types. Should I create a migration script only for those cases that can be mapped?
   
   > I know one difference in the backend is that Period Ratio runs 2 queries and merges them. So I could look at the past 28 days and compare with last year's same period. I'm not sure if Time Shift can do that or it would query/show more than 28 days (which may be ok). What do you think?
   
   How I would that with the period ratio? For time shift you would select the last 28 days and then use "1 year" as the time shift.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org