[GitHub] [incubator-hudi] ovj commented on a change in pull request #777: Fix HUDI-170 Updating hoodie record before inserting it into ExternalSpillableMap

[GitBox <gi...@apache.org>]

ovj commented on a change in pull request #777: Fix HUDI-170 Updating hoodie record before inserting it into ExternalSpillableMap
URL: https://github.com/apache/incubator-hudi/pull/777#discussion_r304196917
 
 

 ##########
 File path: hoodie-client/src/test/java/com/uber/hoodie/TestHoodieClientOnCopyOnWriteStorage.java
 ##########
 @@ -257,14 +258,35 @@ public void testUpsertsPrepped() throws Exception {
         HoodieWriteClient::upsertPreppedRecords, true);
   }
 
+  /**
+   * Test UpsertPrepped API for HoodieRecord's new location tagging during merge handle with
+   * {@link com.uber.hoodie.common.util.collection.ExternalSpillableMap}
+   * Fixes Hudi issue #773.
+   */
+  @Test
+  public void testUpsertsPreppedUsingSpillableDiskForMerge() throws Exception {
 
 Review comment:
   is there any sample test you have in mind? usage of MergeHandle in a good example com.uber.hoodie.func.TestUpdateMapFunction#testSchemaEvolutionOnUpdate?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services