You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by James Peach <jp...@apache.org> on 2013/04/09 22:58:57 UTC
TS-1801 review
Hi Yunkai,
Leif and I reviewed the TS-1801 changes today. It looks good, though we have one suggestion in NodeStatEval(), where there seems to be a possibility that the result_type would not be set correctly. Do you think that the attached patch is correct?
Re: TS-1801 review
Posted by Yunkai Zhang <yu...@gmail.com>.
On Sun, Apr 14, 2013 at 11:46 PM, James Peach <jp...@apache.org> wrote:
> On Apr 14, 2013, at 6:21 AM, Yunkai Zhang <yu...@gmail.com> wrote:
>
> > Hi James:
> >
> > Don't forget to commit your this patch:D
>
> It's in the outbound patch queue ... just taking longer than I'd like to
> get through ...
>
Well.
>
> >
> >
> > On Wed, Apr 10, 2013 at 1:10 PM, James Peach <jp...@apache.org> wrote:
> > On 09/04/2013, at 7:06 PM, Yunkai Zhang <yu...@gmail.com> wrote:
> >
> > > And I think, we are talking to TS-1805:)
> >
> > yes we are ;)
> >
> > >
> > >
> > > On Wed, Apr 10, 2013 at 9:59 AM, Yunkai Zhang <yu...@gmail.com>
> wrote:
> > > Hi James:
> > >
> > > The attached patch is good for me, thanks for your review.
> > >
> > >
> > > On Wed, Apr 10, 2013 at 4:58 AM, James Peach <jp...@apache.org>
> wrote:
> > > Hi Yunkai,
> > >
> > > Leif and I reviewed the TS-1801 changes today. It looks good, though
> we have one suggestion in NodeStatEval(), where there seems to be a
> possibility that the result_type would not be set correctly. Do you think
> that the attached patch is correct?
> > >
> > >
> > >
> > >
> > > J
> > >
> > >
> > >
> > >
> > >
> > >
> > > --
> > > Yunkai Zhang
> > > Work at Taobao
> > >
> > >
> > >
> > > --
> > > Yunkai Zhang
> > > Work at Taobao
> >
> >
> >
> >
> > --
> > Yunkai Zhang
> > Work at Taobao
>
>
--
Yunkai Zhang
Work at Taobao
Re: TS-1801 review
Posted by James Peach <jp...@apache.org>.
On Apr 14, 2013, at 6:21 AM, Yunkai Zhang <yu...@gmail.com> wrote:
> Hi James:
>
> Don't forget to commit your this patch:D
It's in the outbound patch queue ... just taking longer than I'd like to get through ...
>
>
> On Wed, Apr 10, 2013 at 1:10 PM, James Peach <jp...@apache.org> wrote:
> On 09/04/2013, at 7:06 PM, Yunkai Zhang <yu...@gmail.com> wrote:
>
> > And I think, we are talking to TS-1805:)
>
> yes we are ;)
>
> >
> >
> > On Wed, Apr 10, 2013 at 9:59 AM, Yunkai Zhang <yu...@gmail.com> wrote:
> > Hi James:
> >
> > The attached patch is good for me, thanks for your review.
> >
> >
> > On Wed, Apr 10, 2013 at 4:58 AM, James Peach <jp...@apache.org> wrote:
> > Hi Yunkai,
> >
> > Leif and I reviewed the TS-1801 changes today. It looks good, though we have one suggestion in NodeStatEval(), where there seems to be a possibility that the result_type would not be set correctly. Do you think that the attached patch is correct?
> >
> >
> >
> >
> > J
> >
> >
> >
> >
> >
> >
> > --
> > Yunkai Zhang
> > Work at Taobao
> >
> >
> >
> > --
> > Yunkai Zhang
> > Work at Taobao
>
>
>
>
> --
> Yunkai Zhang
> Work at Taobao
Re: TS-1801 review
Posted by Yunkai Zhang <yu...@gmail.com>.
Hi James:
Don't forget to commit your this patch:D
On Wed, Apr 10, 2013 at 1:10 PM, James Peach <jp...@apache.org> wrote:
> On 09/04/2013, at 7:06 PM, Yunkai Zhang <yu...@gmail.com> wrote:
>
> > And I think, we are talking to TS-1805:)
>
> yes we are ;)
>
> >
> >
> > On Wed, Apr 10, 2013 at 9:59 AM, Yunkai Zhang <yu...@gmail.com>
> wrote:
> > Hi James:
> >
> > The attached patch is good for me, thanks for your review.
> >
> >
> > On Wed, Apr 10, 2013 at 4:58 AM, James Peach <jp...@apache.org> wrote:
> > Hi Yunkai,
> >
> > Leif and I reviewed the TS-1801 changes today. It looks good, though we
> have one suggestion in NodeStatEval(), where there seems to be a
> possibility that the result_type would not be set correctly. Do you think
> that the attached patch is correct?
> >
> >
> >
> >
> > J
> >
> >
> >
> >
> >
> >
> > --
> > Yunkai Zhang
> > Work at Taobao
> >
> >
> >
> > --
> > Yunkai Zhang
> > Work at Taobao
>
>
--
Yunkai Zhang
Work at Taobao
Re: TS-1801 review
Posted by James Peach <jp...@apache.org>.
On 09/04/2013, at 7:06 PM, Yunkai Zhang <yu...@gmail.com> wrote:
> And I think, we are talking to TS-1805:)
yes we are ;)
>
>
> On Wed, Apr 10, 2013 at 9:59 AM, Yunkai Zhang <yu...@gmail.com> wrote:
> Hi James:
>
> The attached patch is good for me, thanks for your review.
>
>
> On Wed, Apr 10, 2013 at 4:58 AM, James Peach <jp...@apache.org> wrote:
> Hi Yunkai,
>
> Leif and I reviewed the TS-1801 changes today. It looks good, though we have one suggestion in NodeStatEval(), where there seems to be a possibility that the result_type would not be set correctly. Do you think that the attached patch is correct?
>
>
>
>
> J
>
>
>
>
>
>
> --
> Yunkai Zhang
> Work at Taobao
>
>
>
> --
> Yunkai Zhang
> Work at Taobao
Re: TS-1801 review
Posted by Yunkai Zhang <yu...@gmail.com>.
And I think, we are talking to TS-1805:)
On Wed, Apr 10, 2013 at 9:59 AM, Yunkai Zhang <yu...@gmail.com> wrote:
> Hi James:
>
> The attached patch is good for me, thanks for your review.
>
>
> On Wed, Apr 10, 2013 at 4:58 AM, James Peach <jp...@apache.org> wrote:
>
>> Hi Yunkai,
>>
>> Leif and I reviewed the TS-1801 changes today. It looks good, though we
>> have one suggestion in NodeStatEval(), where there seems to be a
>> possibility that the result_type would not be set correctly. Do you think
>> that the attached patch is correct?
>>
>>
>>
>>
>> J
>>
>>
>>
>>
>
>
> --
> Yunkai Zhang
> Work at Taobao
>
--
Yunkai Zhang
Work at Taobao
Re: TS-1801 review
Posted by Yunkai Zhang <yu...@gmail.com>.
Hi James:
The attached patch is good for me, thanks for your review.
On Wed, Apr 10, 2013 at 4:58 AM, James Peach <jp...@apache.org> wrote:
> Hi Yunkai,
>
> Leif and I reviewed the TS-1801 changes today. It looks good, though we
> have one suggestion in NodeStatEval(), where there seems to be a
> possibility that the result_type would not be set correctly. Do you think
> that the attached patch is correct?
>
>
>
>
> J
>
>
>
>
--
Yunkai Zhang
Work at Taobao