You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by gg...@apache.org on 2016/04/04 19:34:30 UTC
logging-log4j2 git commit: Don't use a magic string.
Repository: logging-log4j2
Updated Branches:
refs/heads/master cc86e96a0 -> d59e6ac96
Don't use a magic string.
Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/d59e6ac9
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/d59e6ac9
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/d59e6ac9
Branch: refs/heads/master
Commit: d59e6ac96b1e0066b4e6d7120a28c61823ab95c9
Parents: cc86e96
Author: ggregory <gg...@apache.org>
Authored: Mon Apr 4 10:34:28 2016 -0700
Committer: ggregory <gg...@apache.org>
Committed: Mon Apr 4 10:34:28 2016 -0700
----------------------------------------------------------------------
.../java/org/apache/logging/log4j/CloseableThreadContext.java | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/d59e6ac9/log4j-api/src/main/java/org/apache/logging/log4j/CloseableThreadContext.java
----------------------------------------------------------------------
diff --git a/log4j-api/src/main/java/org/apache/logging/log4j/CloseableThreadContext.java b/log4j-api/src/main/java/org/apache/logging/log4j/CloseableThreadContext.java
index 53fb0e0..d84f395 100644
--- a/log4j-api/src/main/java/org/apache/logging/log4j/CloseableThreadContext.java
+++ b/log4j-api/src/main/java/org/apache/logging/log4j/CloseableThreadContext.java
@@ -3,6 +3,8 @@ package org.apache.logging.log4j;
import java.util.HashMap;
import java.util.Map;
+import org.apache.logging.log4j.util.Strings;
+
/**
* Adds entries to the {@link ThreadContext stack or map} and them removes them when the object is closed, e.g. as part
* of a try-with-resources.
@@ -105,7 +107,7 @@ public class CloseableThreadContext implements AutoCloseable {
storeAndSet(firstKey, firstValue);
for (int i = 0; i < subsequentKeyValuePairs.length; i += 2) {
final String key = subsequentKeyValuePairs[i];
- final String value = (i + 1) < subsequentKeyValuePairs.length ? subsequentKeyValuePairs[i + 1] : "";
+ final String value = (i + 1) < subsequentKeyValuePairs.length ? subsequentKeyValuePairs[i + 1] : Strings.EMPTY;
storeAndSet(key, value);
}
}